zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] Logic-32 commented on a change in pull request #2502: Adding storage-throttle module to address "over capacity" issues
Date Tue, 30 Apr 2019 15:39:47 GMT
Logic-32 commented on a change in pull request #2502: Adding storage-throttle module to address
"over capacity" issues
URL: https://github.com/apache/incubator-zipkin/pull/2502#discussion_r279813169
 
 

 ##########
 File path: zipkin-collector/core/src/test/java/zipkin2/collector/CollectorTest.java
 ##########
 @@ -26,6 +26,7 @@
 
 import static java.util.Arrays.asList;
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.ArgumentMatchers.*;
 
 Review comment:
   Found it! It's under Brave.  Someone should probably copy it to Zipkin.
   https://github.com/openzipkin/brave/blob/master/.github/CONTRIBUTING.md
   
   I don't use IntelliJ but I'll see if I can mimic the settings in Netbeans.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message