zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-reporter-java] adriancole commented on issue #142: include user agent in http reporting
Date Tue, 30 Apr 2019 00:22:02 GMT
adriancole commented on issue #142: include user agent in http reporting
URL: https://github.com/apache/incubator-zipkin-reporter-java/issues/142#issuecomment-487787786
 
 
   probably we should prefer user agent formatting right? https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent
   
   ```
   User-Agent: <product> / <product-version> <comment>
   
   Common format for web browsers:
   
   User-Agent: Mozilla/<version> (<system-information>) <platform> (<platform-details>)
<extensions>
   ```
   
   Ex here's FF actually sending during this issue
   
   ```
   Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:66.0) Gecko/20100101 Firefox/66.0
   ```
   
   Notable change is slash between thing and version of thing. Also, note there are multiple
groups from least to most specific.
   
   I'd guess that we could do something to tell it is zipkin api, if we like... or skip that
and save bytes by not sending the prefix. However, with the prefix different language reporters
can have common analysis (if that's the goal)
   
   Ex. assuming this is the latest version of the zipkin api endpoint, we can say zipkin/2.1.0
or zipkin-api/2.1.0 after that give the version of the module in use
   ```
   zipkin/2.1.0 zipkin-reporter-okhttp3/2.9.3
   ```
   
   carefully cc'ing @apache/zipkin-committers 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message