zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-website] abesto commented on issue #5: fix: reenables the zipkin-api filter.
Date Fri, 26 Apr 2019 17:27:03 GMT
abesto commented on issue #5: fix: reenables the zipkin-api filter.
URL: https://github.com/apache/incubator-zipkin-website/pull/5#issuecomment-487136411
 
 
   Cool stuff! Since we're not directing people to zipkin.apache.org yet, I think you should
be fine just merging this and iterating on the Jenkinsfile on master.
   
   One thing to watch out for will be that we'll want to trigger a build for `website` when
there's a change on `api`, to make sure it picks up the new Swagger defs. Or we could go about
it the other way, and extend the build process of `zipkin-api` so that it directly commits
into the `asf-site` branch of the `website` repo.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message