zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-website] jcchavezs commented on a change in pull request #5: fix: reenables the zipkin-api filter.
Date Fri, 26 Apr 2019 11:04:49 GMT
jcchavezs commented on a change in pull request #5: fix: reenables the zipkin-api filter.
URL: https://github.com/apache/incubator-zipkin-website/pull/5#discussion_r278902941
 
 

 ##########
 File path: _config.yml
 ##########
 @@ -16,3 +16,7 @@ defaults:
       weight: 100   # Used to sort navbar items. Lower weight goes higher on the list.
 
 highlighter: rouge
+
+# This is the best we can get to avoid the 
 
 Review comment:
   This is the best I could get to not to load the build with useless files from the submodule.
I tried every glob expression to only include the `yaml` and `proto` but I failed to get a
decent result. Current files included are:
   <img width="200" alt="image" src="https://user-images.githubusercontent.com/3075074/56803762-d8166080-6823-11e9-9df1-62d6dbda6f09.png">
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message