From commits-return-5734-archive-asf-public=cust-asf.ponee.io@zeppelin.apache.org Wed Dec 18 09:10:01 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 968B818065B for ; Wed, 18 Dec 2019 10:10:01 +0100 (CET) Received: (qmail 13202 invoked by uid 500); 18 Dec 2019 09:10:00 -0000 Mailing-List: contact commits-help@zeppelin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zeppelin.apache.org Delivered-To: mailing list commits@zeppelin.apache.org Received: (qmail 13192 invoked by uid 99); 18 Dec 2019 09:10:00 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Dec 2019 09:10:00 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 3B8678D80D; Wed, 18 Dec 2019 09:10:00 +0000 (UTC) Date: Wed, 18 Dec 2019 09:09:59 +0000 To: "commits@zeppelin.apache.org" Subject: [zeppelin] branch master updated: [ZEPPELIN-4301] js double precision loss problem MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <157666019969.796.2839331328477178673@gitbox.apache.org> From: zjffdu@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: zeppelin X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 3e186591e4989a4c0ffc9ebd8ecbf5e901f608e3 X-Git-Newrev: c07a52bec7447842a3501e221b2ae794754b80bd X-Git-Rev: c07a52bec7447842a3501e221b2ae794754b80bd X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. zjffdu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/zeppelin.git The following commit(s) were added to refs/heads/master by this push: new c07a52b [ZEPPELIN-4301] js double precision loss problem c07a52b is described below commit c07a52bec7447842a3501e221b2ae794754b80bd Author: curlsli AuthorDate: Fri Aug 16 14:45:20 2019 +0800 [ZEPPELIN-4301] js double precision loss problem ### What is this PR for? JS double precision loss problem. ### What type of PR is it? [Bug Fix] ### Todos * [x] - Fix ### What is the Jira issue? * [https://issues.apache.org/jira/browse/ZEPPELIN-4301](https://issues.apache.org/jira/browse/ZEPPELIN-4301) ### How should this be tested? * CREATE TABLE 'student' ('id' BIGINT, 'age' INT) * insert into student values (6703273802681287331, 2) * select * from student ### Screenshots (if appropriate) ![image](https://user-images.githubusercontent.com/3116382/63078478-2f287880-bf6e-11e9-9454-dc25e1e70dee.png) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: curlsli Closes #3425 from curlsli/master and squashes the following commits: 4cac2def3 [curlsli] style: delete header comment 3cb67f2c3 [curlsli] debug: js double precision loss problem --- zeppelin-web/src/app/tabledata/tabledata.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zeppelin-web/src/app/tabledata/tabledata.js b/zeppelin-web/src/app/tabledata/tabledata.js index ab96c33..f75b94e 100644 --- a/zeppelin-web/src/app/tabledata/tabledata.js +++ b/zeppelin-web/src/app/tabledata/tabledata.js @@ -60,7 +60,7 @@ export default class TableData extends Dataset { } else { let valueOfCol; if (!(col[0] === '0' || col[0] === '+' || col.length > float64MaxDigits)) { - if (!isNaN(valueOfCol = parseFloat(col)) && isFinite(col)) { + if (!isNaN(valueOfCol = col) && isFinite(col)) { col = valueOfCol; } }