zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zjf...@apache.org
Subject [zeppelin] branch master updated: [ZEPPELIN-4301] js double precision loss problem
Date Wed, 18 Dec 2019 09:09:59 GMT
This is an automated email from the ASF dual-hosted git repository.

zjffdu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/master by this push:
     new c07a52b  [ZEPPELIN-4301]  js double precision loss problem
c07a52b is described below

commit c07a52bec7447842a3501e221b2ae794754b80bd
Author: curlsli <curlsli@tencent.com>
AuthorDate: Fri Aug 16 14:45:20 2019 +0800

    [ZEPPELIN-4301]  js double precision loss problem
    
    ### What is this PR for?
    JS double precision loss problem.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [x] - Fix
    
    ### What is the Jira issue?
    *  [https://issues.apache.org/jira/browse/ZEPPELIN-4301](https://issues.apache.org/jira/browse/ZEPPELIN-4301)
    
    ### How should this be tested?
    * CREATE TABLE 'student' ('id' BIGINT, 'age' INT)
    * insert into student values (6703273802681287331, 2)
    * select * from student
    
    ### Screenshots (if appropriate)
    ![image](https://user-images.githubusercontent.com/3116382/63078478-2f287880-bf6e-11e9-9454-dc25e1e70dee.png)
    
    ### Questions:
    * Does the licenses files need update?
          No
    * Is there breaking changes for older versions?
          No
    * Does this needs documentation?
         No
    
    Author: curlsli <curlsli@tencent.com>
    
    Closes #3425 from curlsli/master and squashes the following commits:
    
    4cac2def3 [curlsli] style: delete header comment
    3cb67f2c3 [curlsli] debug: js double precision loss problem
---
 zeppelin-web/src/app/tabledata/tabledata.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/zeppelin-web/src/app/tabledata/tabledata.js b/zeppelin-web/src/app/tabledata/tabledata.js
index ab96c33..f75b94e 100644
--- a/zeppelin-web/src/app/tabledata/tabledata.js
+++ b/zeppelin-web/src/app/tabledata/tabledata.js
@@ -60,7 +60,7 @@ export default class TableData extends Dataset {
         } else {
           let valueOfCol;
           if (!(col[0] === '0' || col[0] === '+' || col.length > float64MaxDigits)) {
-            if (!isNaN(valueOfCol = parseFloat(col)) && isFinite(col)) {
+            if (!isNaN(valueOfCol = col) && isFinite(col)) {
               col = valueOfCol;
             }
           }


Mime
View raw message