zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zjf...@apache.org
Subject [zeppelin] branch master updated: [MINOR] Fix notebook filter search
Date Tue, 10 Dec 2019 03:53:18 GMT
This is an automated email from the ASF dual-hosted git repository.

zjffdu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/master by this push:
     new 32e2231  [MINOR] Fix notebook filter search
32e2231 is described below

commit 32e223148bec7ad7d2b7f5d9c37cdb4381740316
Author: LeeDongMyeong <dev.dmlee@gmail.com>
AuthorDate: Mon Dec 9 21:13:18 2019 +0900

    [MINOR] Fix notebook filter search
    
    ### What is this PR for?
    Unlike the navigation bar, the home notebook filter returns values ‚Äč‚Äčthat belong to
a path rather than a note name.
    
    ### What type of PR is it?
    [Bug Fix | Improvement]
    
    ### Todos
    * [x] - Filter by note name
    
    ### What is the Jira issue?
    No
    
    ### Screenshots (if appropriate)
    (before)
    <img width="1077" alt="Screen Shot 2019-12-09 at 8 44 55 PM" src="https://user-images.githubusercontent.com/42430609/70434966-0140e400-1ac9-11ea-9a2b-a288a53d3111.png">
    (after)
    <img width="1077" alt="Screen Shot 2019-12-09 at 8 46 52 PM" src="https://user-images.githubusercontent.com/42430609/70434974-03a33e00-1ac9-11ea-99bc-3698d40ee604.png">
    
    Author: LeeDongMyeong <dev.dmlee@gmail.com>
    
    Closes #3547 from eldiem/fix-filter-note and squashes the following commits:
    
    1d772bc1a [LeeDongMyeong] Fix notebook filter search
---
 zeppelin-web/src/app/home/home.controller.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/zeppelin-web/src/app/home/home.controller.js b/zeppelin-web/src/app/home/home.controller.js
index 98038b2..14361d6 100644
--- a/zeppelin-web/src/app/home/home.controller.js
+++ b/zeppelin-web/src/app/home/home.controller.js
@@ -139,7 +139,7 @@ function HomeCtrl($scope, noteListFactory, websocketMsgSrv, $rootScope,
arrayOrd
       return true;
     }
 
-    let noteName = note.path;
+    let noteName = note.name;
     if (noteName.toLowerCase().indexOf($scope.query.q.toLowerCase()) > -1) {
       return true;
     }


Mime
View raw message