zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m...@apache.org
Subject [zeppelin] branch branch-0.8 updated: [ZEPPELIN-4280] [Followup] Add comments
Date Fri, 27 Sep 2019 16:20:43 GMT
This is an automated email from the ASF dual-hosted git repository.

moon pushed a commit to branch branch-0.8
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/branch-0.8 by this push:
     new e2e1d19  [ZEPPELIN-4280] [Followup] Add comments
e2e1d19 is described below

commit e2e1d1968c894937ae031f330e4a25204d822906
Author: Lee moon soo <moon@apache.org>
AuthorDate: Wed Sep 25 12:19:42 2019 -0700

    [ZEPPELIN-4280] [Followup] Add comments
    
    ### What is this PR for?
    This is followup issue for ZEPPELIN-4280, to add some comments on the code.
    
    ### What type of PR is it?
    Documentation
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-4280
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    
    Author: Lee moon soo <moon@apache.org>
    
    Closes #3461 from Leemoonsoo/ZEPPELIN-4280-followup and squashes the following commits:
    
    75d4995ea [Lee moon soo] add comment
    
    (cherry picked from commit 7d74b922c20d66bf6610e18cd40ad04b5897956a)
    Signed-off-by: Lee moon soo <moon@apache.org>
---
 zeppelin-web/src/app/notebook/paragraph/result/result.controller.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js b/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
index 1723e7e..28c74a9 100644
--- a/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
+++ b/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
@@ -802,9 +802,13 @@ function ResultCtrl($scope, $rootScope, $route, $window, $routeParams,
$location
         newConfig.graph.values = newConfig.graph.commonSetting.pivot.values;
         delete newConfig.graph.commonSetting.pivot;
       }
+
+      // don't send commitParagraphResult when config is the same.
+      // see https://issues.apache.org/jira/browse/ZEPPELIN-4280.
       if (angular.equals($scope.config, newConfig)) {
         return;
       }
+
       console.debug('committVizConfig', newConfig);
       let newParams = angular.copy(paragraph.settings.params);
       commitParagraphResult(paragraph.title, paragraph.text, newConfig, newParams);


Mime
View raw message