zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zjf...@apache.org
Subject [zeppelin] branch branch-0.8 updated: [ZEPPELIN-4299] disable autocomplete in note-name-filter and interpreter search
Date Wed, 25 Sep 2019 01:45:19 GMT
This is an automated email from the ASF dual-hosted git repository.

zjffdu pushed a commit to branch branch-0.8
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/branch-0.8 by this push:
     new 9296c3c  [ZEPPELIN-4299] disable autocomplete in note-name-filter and interpreter
search
9296c3c is described below

commit 9296c3c3a944045e502803d2ee0832397e5ca61a
Author: Jaehoon Jeong <jaehoon.jeong@woowahan.com>
AuthorDate: Sat Aug 10 00:21:23 2019 +0900

    [ZEPPELIN-4299] disable autocomplete in note-name-filter and interpreter search
    
    ### What is this PR for?
    In chrome browser,
    After login with saved-autocomplete feature in chrome and input username in note filter
then refresh, note filter is filled username automatically.
    It also happen in interpreter page.
    
    this happening with just chrome.
    in past, it is not happening this in chrome.
    
    I think that disable auto-complete feature in note filter is better.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    * [x] - modify
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-4299
    
    ### How should this be tested?
    * Login with autocomplete feature in chrome
    * input username in note filter
    * refresh
    * refresh In interpreter page
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
        * No
    * Is there breaking changes for older versions?
        * No
    * Does this needs documentation?
        * No
    
    Author: Jaehoon Jeong <jaehoon.jeong@woowahan.com>
    
    Closes #3423 from woowahan-jaehoon/ZEPPELIN-4299 and squashes the following commits:
    
    536ea7900 [Jaehoon Jeong] [ZEPPELIN-4299] disable autocomplete in note search and interpreter
search
    
    (cherry picked from commit c778a9dc1bd7253537de54f3c2f6660f8acc9231)
---
 zeppelin-web/src/app/interpreter/interpreter.html              | 10 ++++++----
 .../src/components/note-name-filter/note-name-filter.html      |  2 ++
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/zeppelin-web/src/app/interpreter/interpreter.html b/zeppelin-web/src/app/interpreter/interpreter.html
index c1d90cc..a4ef4ea 100644
--- a/zeppelin-web/src/app/interpreter/interpreter.html
+++ b/zeppelin-web/src/app/interpreter/interpreter.html
@@ -41,10 +41,12 @@ limitations under the License.
     <div class="row">
       <div class="col-md-4">
         <div class="input-group" style="margin-top: 10px">
-          <input type="text" ng-model="searchInterpreter"
-                 class="form-control ng-pristine ng-untouched ng-valid ng-empty"
-                 ng-model-options="{ updateOn: 'default blur', debounce: { 'default': 300,
'blur': 0 } }"
-                 placeholder="Search interpreters"/>
+          <form>
+            <input type="text" ng-model="searchInterpreter"
+                   class="form-control ng-pristine ng-untouched ng-valid ng-empty"
+                   ng-model-options="{ updateOn: 'default blur', debounce: { 'default': 300,
'blur': 0 } }"
+                   placeholder="Search interpreters"/>
+          </form>
           <span class="input-group-btn">
             <button type="submit" class="btn btn-default" ng-disabled="!navbar.connected">
               <i class="glyphicon glyphicon-search"></i>
diff --git a/zeppelin-web/src/components/note-name-filter/note-name-filter.html b/zeppelin-web/src/components/note-name-filter/note-name-filter.html
index 071cba4..e1bcc94 100644
--- a/zeppelin-web/src/components/note-name-filter/note-name-filter.html
+++ b/zeppelin-web/src/components/note-name-filter/note-name-filter.html
@@ -11,9 +11,11 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License.
 -->
+<form>
 <input type="text"
        class="note-name-query form-control"
        ng-click="$event.stopPropagation()"
        placeholder="&#xf002 Filter"
        ng-model="$parent.query.q"
        ng-model-options="{ updateOn: 'default blur', debounce: { 'default': 300, 'blur':
0 } }" />
+</form>


Mime
View raw message