zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m...@apache.org
Subject [zeppelin] branch branch-0.8 updated: [ZEPPELIN-4166] Change default binding address to 127.0.0.1 (previously 0.0.0.0)
Date Wed, 18 Sep 2019 16:41:22 GMT
This is an automated email from the ASF dual-hosted git repository.

moon pushed a commit to branch branch-0.8
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/branch-0.8 by this push:
     new 14bbeb6  [ZEPPELIN-4166] Change default binding address to 127.0.0.1 (previously
0.0.0.0)
14bbeb6 is described below

commit 14bbeb6d99a16b46545fbdc0850e3b10ae8cb703
Author: Lee moon soo <moon@apache.org>
AuthorDate: Tue Sep 17 14:45:29 2019 -0700

    [ZEPPELIN-4166] Change default binding address to 127.0.0.1 (previously 0.0.0.0)
    
    This PR changes default Zeppelin server binding address from `0.0.0.0` to `127.0.0.1`.
    Also update related configuration templates and document.
    
    mprovement
    
    https://issues.apache.org/jira/browse/ZEPPELIN-4166
    
    Build and run Zeppelin server with default configuration and see if default port is listening
in address 127.0.0.1 instead of 0.0.0.0 (netstat -na | grep 8080)
    
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? yes
    
    Author: Lee moon soo <moon@apache.org>
    
    Closes #3450 from Leemoonsoo/ZEPPELIN-4166 and squashes the following commits:
    
    54dd81237 [Lee moon soo] update upgrade to guide default bind address change
    41741d282 [Lee moon soo] update doc
    34e2ca8f7 [Lee moon soo] update configuration templates
    18aeb8b06 [Lee moon soo] bind 127.0.0.1 instead of 0.0.0.0 by default
    
    (cherry picked from commit 7d7628eab8559093b37b2ae05a9f262ca75b3d56)
    Signed-off-by: Lee moon soo <moon@apache.org>
---
 conf/zeppelin-env.sh.template                                       | 2 ++
 conf/zeppelin-site.xml.template                                     | 4 ++--
 docs/setup/operation/configuration.md                               | 6 ++++++
 docs/setup/operation/upgrading.md                                   | 2 ++
 .../main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java   | 2 +-
 5 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/conf/zeppelin-env.sh.template b/conf/zeppelin-env.sh.template
index 5aab0e0..b7f4ee6 100644
--- a/conf/zeppelin-env.sh.template
+++ b/conf/zeppelin-env.sh.template
@@ -18,6 +18,8 @@
 
 # export JAVA_HOME=
 # export MASTER=                 		# Spark master url. eg. spark://master_addr:7077. Leave
empty if you want to use local mode.
+# export ZEPPELIN_ADDR                          # Bind address (default 127.0.0.1)
+# export ZEPPELIN_PORT                          # port number to listen (default 8080)
 # export ZEPPELIN_JAVA_OPTS      		# Additional jvm options. for example, export ZEPPELIN_JAVA_OPTS="-Dspark.executor.memory=8g
-Dspark.cores.max=16"
 # export ZEPPELIN_MEM            		# Zeppelin jvm mem options Default -Xms1024m -Xmx1024m
-XX:MaxPermSize=512m
 # export ZEPPELIN_INTP_MEM       		# zeppelin interpreter process jvm mem options. Default
-Xms1024m -Xmx1024m -XX:MaxPermSize=512m
diff --git a/conf/zeppelin-site.xml.template b/conf/zeppelin-site.xml.template
index e665a9b..0ca09c0 100755
--- a/conf/zeppelin-site.xml.template
+++ b/conf/zeppelin-site.xml.template
@@ -21,8 +21,8 @@
 
 <property>
   <name>zeppelin.server.addr</name>
-  <value>0.0.0.0</value>
-  <description>Server address</description>
+  <value>127.0.0.1</value>
+  <description>Server binding address</description>
 </property>
 
 <property>
diff --git a/docs/setup/operation/configuration.md b/docs/setup/operation/configuration.md
index b831918..61756c8 100644
--- a/docs/setup/operation/configuration.md
+++ b/docs/setup/operation/configuration.md
@@ -40,6 +40,12 @@ If both are defined, then the **environment variables** will take priority.
     <th class="col-md-4">Description</th>
   </tr>
   <tr>
+    <td><h6 class="properties">ZEPPELIN_ADDR</h6></td>
+    <td><h6 class="properties">zeppelin.server.addr</h6></td>
+    <td>127.0.0.1</td>
+    <td>Zeppelin server binding address</td>
+  </tr>
+  <tr>
     <td><h6 class="properties">ZEPPELIN_PORT</h6></td>
     <td><h6 class="properties">zeppelin.server.port</h6></td>
     <td>8080</td>
diff --git a/docs/setup/operation/upgrading.md b/docs/setup/operation/upgrading.md
index 8ea3697..75c2327 100644
--- a/docs/setup/operation/upgrading.md
+++ b/docs/setup/operation/upgrading.md
@@ -45,6 +45,8 @@ To set all your "writers" to "runners":
 2. Move directory **docs/assets/themes/zeppelin/note/FixReaders** to new `notebook` directory,
 3. Start the new Zeppelin and run note **System/Migrate from 0.7**.
 
+### Upgrading from Zeppelin 0.8.1 (and before) to 0.8.2 (and later)
+ - From 0.8.2, Zeppelin server bind `127.0.0.1` by default instead of `0.0.0.0`. Configure
`zeppelin.server.addr` property or `ZEPPELIN_ADDR` env variable to change.         
 
 ### Upgrading from Zeppelin 0.7 to 0.8
 
diff --git a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
index 245f7b9..5b4ebc0 100644
--- a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
+++ b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
@@ -643,7 +643,7 @@ public class ZeppelinConfiguration extends XMLConfiguration {
    */
   public static enum ConfVars {
     ZEPPELIN_HOME("zeppelin.home", "./"),
-    ZEPPELIN_ADDR("zeppelin.server.addr", "0.0.0.0"),
+    ZEPPELIN_ADDR("zeppelin.server.addr", "127.0.0.1"),
     ZEPPELIN_PORT("zeppelin.server.port", 8080),
     ZEPPELIN_SERVER_CONTEXT_PATH("zeppelin.server.context.path", "/"),
     ZEPPELIN_SSL("zeppelin.ssl", false),


Mime
View raw message