zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m...@apache.org
Subject zeppelin git commit: docs [branch-0.8]: REST API JSON response status fix
Date Fri, 16 Nov 2018 20:00:06 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/branch-0.8 2ca8d19ba -> 04532305e


docs [branch-0.8]: REST API JSON response status fix

### What is this PR for?
Since v0.8.0, REST API JSON response `status` attribute has changed from `CREATED` to `OK`.

Related source code:
* https://github.com/apache/zeppelin/blob/master/zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRestApi.java
* https://github.com/apache/zeppelin/blob/master/zeppelin-server/src/main/java/org/apache/zeppelin/rest/InterpreterRestApi.java

### What type of PR is it?
Documentation

### Questions:
* Shall I add tests to check the returned `status` in:
   * https://github.com/apache/zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/rest/InterpreterRestApiTest.java
   * https://github.com/apache/zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/rest/NotebookRestApiTest.java

Author: John Lau <jolks@outlook.com>

Closes #3225 from jolks/branch-0.8_doc_rest_api_fix and squashes the following commits:

139706003 [John Lau] REST API JSON response status fix


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/04532305
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/04532305
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/04532305

Branch: refs/heads/branch-0.8
Commit: 04532305e22704b05727c9098ae23f9a622aa725
Parents: 2ca8d19
Author: John Lau <jolks@outlook.com>
Authored: Thu Nov 15 02:08:04 2018 +0900
Committer: Lee moon soo <moon@apache.org>
Committed: Sat Nov 17 05:00:02 2018 +0900

----------------------------------------------------------------------
 docs/usage/rest_api/interpreter.md | 2 +-
 docs/usage/rest_api/notebook.md    | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/04532305/docs/usage/rest_api/interpreter.md
----------------------------------------------------------------------
diff --git a/docs/usage/rest_api/interpreter.md b/docs/usage/rest_api/interpreter.md
index 23a7c66..c750289 100644
--- a/docs/usage/rest_api/interpreter.md
+++ b/docs/usage/rest_api/interpreter.md
@@ -315,7 +315,7 @@ The role of registered interpreters, settings and interpreters group are
describ
       <td>
         <pre>
 {
-  "status": "CREATED",
+  "status": "OK",
   "message": "",
   "body": {
     "id": "2AYW25ANY",

http://git-wip-us.apache.org/repos/asf/zeppelin/blob/04532305/docs/usage/rest_api/notebook.md
----------------------------------------------------------------------
diff --git a/docs/usage/rest_api/notebook.md b/docs/usage/rest_api/notebook.md
index 3cbfc52..74d98db 100644
--- a/docs/usage/rest_api/notebook.md
+++ b/docs/usage/rest_api/notebook.md
@@ -132,7 +132,7 @@ Notebooks REST API supports the following operations: List, Create, Get,
Delete,
       <td> sample JSON response </td>
       <td><pre>
 {
-  "status": "CREATED",
+  "status": "OK",
   "message": "",
   "body": "2AZPHY918"
 }</pre></td>
@@ -344,7 +344,7 @@ Notebooks REST API supports the following operations: List, Create, Get,
Delete,
       <td> sample JSON response </td>
       <td><pre>
 {
-  "status": "CREATED",
+  "status": "OK",
   "message": "",
   "body": "2AZPHY918"
 }</pre></td>
@@ -455,7 +455,7 @@ Notebooks REST API supports the following operations: List, Create, Get,
Delete,
       <td>sample JSON response</td>
       <td><pre>
 {
-  "status": "CREATED",
+  "status": "OK",
   "message": "",
   "body": "2AZPHY918"
 }</pre></td>
@@ -636,7 +636,7 @@ Notebooks REST API supports the following operations: List, Create, Get,
Delete,
       <td> sample JSON response </td>
       <td><pre>
 {
-  "status": "CREATED",
+  "status": "OK",
   "message": "",
   "body": "20151218-100330\_1754029574"
 }</pre></td>


Mime
View raw message