zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jongy...@apache.org
Subject zeppelin git commit: [ZEPPELIN-3123] Fix to create pid per each interpreter
Date Fri, 06 Jul 2018 06:46:28 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/master ca7c9cd81 -> bba8d3013


[ZEPPELIN-3123] Fix to create pid per each interpreter

### What is this PR for?
When interpreter policy is not set globally, zeppelin run many interpreters but pid file is
still single.
This PR is for fix this.

### What type of PR is it?
[Bug Fix]

### Todos
* [x] - Fix

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3123

### How should this be tested?
If set 'per user' or 'per note' for some interpreter and run it, zeppelin have to create pid
files per each interpreter.

### Questions:
* Does the licenses files need update?
    * No
* Is there breaking changes for older versions?
    * No
* Does this needs documentation?
    * No

Author: Jaehoon Jeong <jaehoon.jeong@woowahan.com>

Closes #2716 from woowahan-jaehoon/ZEPPELIN-3123 and squashes the following commits:

58141598a [Jaehoon Jeong] [ZEPPELIN-3123] Fix to create pid files per each interpreter


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/bba8d301
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/bba8d301
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/bba8d301

Branch: refs/heads/master
Commit: bba8d3013385abd1a6ce3e723f97365549d742ca
Parents: ca7c9cd
Author: Jaehoon Jeong <jaehoon.jeong@woowahan.com>
Authored: Fri Dec 29 21:47:13 2017 +0900
Committer: Jongyoul Lee <jongyoul@apache.org>
Committed: Fri Jul 6 15:46:23 2018 +0900

----------------------------------------------------------------------
 bin/interpreter.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/bba8d301/bin/interpreter.sh
----------------------------------------------------------------------
diff --git a/bin/interpreter.sh b/bin/interpreter.sh
index 64b3af4..9ad9ee0 100755
--- a/bin/interpreter.sh
+++ b/bin/interpreter.sh
@@ -92,7 +92,7 @@ HOSTNAME=$(hostname)
 ZEPPELIN_SERVER=org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer
 
 INTERPRETER_ID=$(basename "${INTERPRETER_DIR}")
-ZEPPELIN_PID="${ZEPPELIN_PID_DIR}/zeppelin-interpreter-${INTERPRETER_ID}-${ZEPPELIN_IDENT_STRING}-${HOSTNAME}.pid"
+ZEPPELIN_PID="${ZEPPELIN_PID_DIR}/zeppelin-interpreter-${INTERPRETER_ID}-${ZEPPELIN_IDENT_STRING}-${HOSTNAME}-${PORT}.pid"
 ZEPPELIN_LOGFILE="${ZEPPELIN_LOG_DIR}/zeppelin-interpreter-${INTERPRETER_SETTING_NAME}-"
 
 if [[ -z "$ZEPPELIN_IMPERSONATE_CMD" ]]; then


Mime
View raw message