From commits-return-4555-archive-asf-public=cust-asf.ponee.io@zeppelin.apache.org Wed Jun 13 10:51:56 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 50B02180609 for ; Wed, 13 Jun 2018 10:51:56 +0200 (CEST) Received: (qmail 37392 invoked by uid 500); 13 Jun 2018 08:51:55 -0000 Mailing-List: contact commits-help@zeppelin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zeppelin.apache.org Delivered-To: mailing list commits@zeppelin.apache.org Received: (qmail 37383 invoked by uid 99); 13 Jun 2018 08:51:55 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jun 2018 08:51:55 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 3FE72DFCBA; Wed, 13 Jun 2018 08:51:55 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: rkamath@apache.org To: commits@zeppelin.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: zeppelin git commit: [ZEPPELIN-3492] The paragraph's table does not scroll if there is a large cell Date: Wed, 13 Jun 2018 08:51:55 +0000 (UTC) Repository: zeppelin Updated Branches: refs/heads/branch-0.8 fd54540f7 -> 7dfbd060a [ZEPPELIN-3492] The paragraph's table does not scroll if there is a large cell When scrolling (with the mouse wheel), the contents of the table jump and do not scroll down. The scroll bar is working fine. Often this happens if the table has a cell with a large height. [Bug Fix] [ZEPPELIN-3492](https://issues.apache.org/jira/browse/ZEPPELIN-3492) [Text](https://github.com/apache/zeppelin/files/2030555/paragraphText.txt) of the paragraph (python interpreter) ![peek_before](https://user-images.githubusercontent.com/30798933/40417963-c3d158a4-5e89-11e8-8c68-5a0397281c75.gif) ![peek_after](https://user-images.githubusercontent.com/30798933/40417977-ccf60f1a-5e89-11e8-88b3-c7855a198e2d.gif) * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Savalek Closes #2982 from Savalek/ZEPPELIN-3492 and squashes the following commits: 06ef2e616 [Savalek] [ZEPPELIN-3492] fix paragraph's table scroll Change-Id: I22218a65345f7e84d65bd50b0d110ceb86b8ecbf (cherry picked from commit f22bbde1ce83b10f0821e26168cf6cd058b94486) Signed-off-by: Renjith Kamath Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/7dfbd060 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/7dfbd060 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/7dfbd060 Branch: refs/heads/branch-0.8 Commit: 7dfbd060a47980904b59b8d638fa3b9b6efde9ac Parents: fd54540 Author: Savalek Authored: Wed May 23 12:58:30 2018 +0300 Committer: Renjith Kamath Committed: Wed Jun 13 14:21:49 2018 +0530 ---------------------------------------------------------------------- zeppelin-web/src/app/visualization/builtins/visualization-table.js | 1 + 1 file changed, 1 insertion(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/7dfbd060/zeppelin-web/src/app/visualization/builtins/visualization-table.js ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/visualization/builtins/visualization-table.js b/zeppelin-web/src/app/visualization/builtins/visualization-table.js index 831bf95..30d3291 100644 --- a/zeppelin-web/src/app/visualization/builtins/visualization-table.js +++ b/zeppelin-web/src/app/visualization/builtins/visualization-table.js @@ -153,6 +153,7 @@ export default class TableVisualization extends Visualization { saveTreeView: true, saveFilter: true, saveSelection: false, + customScroller: (uiGrid) => uiGrid.on('wheel', (event) => event.stopPropagation()), }; return gridOptions;