From commits-return-4530-archive-asf-public=cust-asf.ponee.io@zeppelin.apache.org Thu Jun 7 09:23:45 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 38E0E180663 for ; Thu, 7 Jun 2018 09:23:45 +0200 (CEST) Received: (qmail 80651 invoked by uid 500); 7 Jun 2018 07:23:44 -0000 Mailing-List: contact commits-help@zeppelin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zeppelin.apache.org Delivered-To: mailing list commits@zeppelin.apache.org Received: (qmail 80642 invoked by uid 99); 7 Jun 2018 07:23:44 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jun 2018 07:23:44 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 30185E04BC; Thu, 7 Jun 2018 07:23:44 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: zjffdu@apache.org To: commits@zeppelin.apache.org Message-Id: <6282f23798604f359b5e73e85671c976@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: zeppelin git commit: [MINOR] Verify appId is not null in LivyInterpreterIT Date: Thu, 7 Jun 2018 07:23:44 +0000 (UTC) Repository: zeppelin Updated Branches: refs/heads/master 48647e597 -> 6fc3057d5 [MINOR] Verify appId is not null in LivyInterpreterIT ### What is this PR for? Someone complain that they could not get appId, this PR just try to verify appId returned by livy rest api is not null. ### What type of PR is it? [Improvement] ### Todos * [ ] - Task ### What is the Jira issue? * No jira created ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang Closes #2999 from zjffdu/minor_livy and squashes the following commits: eae0cf58c [Jeff Zhang] [MINOR] Verify appId is null in LivyInterpreterIT Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/6fc3057d Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/6fc3057d Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/6fc3057d Branch: refs/heads/master Commit: 6fc3057d529691e697361ef9a67e21cac75e21ed Parents: 48647e5 Author: Jeff Zhang Authored: Fri Jun 1 21:58:40 2018 +0800 Committer: Jeff Zhang Committed: Thu Jun 7 15:23:39 2018 +0800 ---------------------------------------------------------------------- .../src/test/java/org/apache/zeppelin/livy/LivyInterpreterIT.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/6fc3057d/livy/src/test/java/org/apache/zeppelin/livy/LivyInterpreterIT.java ---------------------------------------------------------------------- diff --git a/livy/src/test/java/org/apache/zeppelin/livy/LivyInterpreterIT.java b/livy/src/test/java/org/apache/zeppelin/livy/LivyInterpreterIT.java index 5deb52d..76e2103 100644 --- a/livy/src/test/java/org/apache/zeppelin/livy/LivyInterpreterIT.java +++ b/livy/src/test/java/org/apache/zeppelin/livy/LivyInterpreterIT.java @@ -495,7 +495,8 @@ public class LivyInterpreterIT { InterpreterResult result = sparkInterpreter.interpret("sc.version", context); assertEquals(InterpreterResult.Code.SUCCESS, result.code()); assertEquals(2, result.message().size()); - assertTrue(result.message().get(1).getData().contains("Spark Application Id")); + // check yarn appId and ensure it is not null + assertTrue(result.message().get(1).getData().contains("Spark Application Id: application_")); // html output String htmlCode = "println(\"%html

hello

\")";