From commits-return-4562-archive-asf-public=cust-asf.ponee.io@zeppelin.apache.org Thu Jun 14 05:12:14 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 23E42180609 for ; Thu, 14 Jun 2018 05:12:13 +0200 (CEST) Received: (qmail 67728 invoked by uid 500); 14 Jun 2018 03:12:13 -0000 Mailing-List: contact commits-help@zeppelin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zeppelin.apache.org Delivered-To: mailing list commits@zeppelin.apache.org Received: (qmail 67719 invoked by uid 99); 14 Jun 2018 03:12:13 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Jun 2018 03:12:13 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id DAC1DE049E; Thu, 14 Jun 2018 03:12:12 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: zjffdu@apache.org To: commits@zeppelin.apache.org Message-Id: <3a1b35772bab4b9dab4ccbff7140e94e@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: zeppelin git commit: [ZEPPELIN-3522] String "defaultValue" instead of boolean in some "interpreter-settings.json" files Date: Thu, 14 Jun 2018 03:12:12 +0000 (UTC) Repository: zeppelin Updated Branches: refs/heads/branch-0.8 9631a7d9a -> 7b0c21626 [ZEPPELIN-3522] String "defaultValue" instead of boolean in some "interpreter-settings.json" files ### What is this PR for? The _interpreter-settings.json_ file for each interpreter has details of each configurable parameter for that interpreter. Each parameter also has a _defaultValue_ setting. For boolean-typed parameters the _defaultValue_ must be set to _true_ or _false_. But in some _interpreter-settings.json_ files, the _defaultValue_ has been set to the string values _"true"_ or _"false"_ (the quote marks are included in the value provided). ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3522 ### How should this be tested? CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Sanjay Dasgupta Closes #2998 from sanjaydasgupta/zepp-3522-string-default-value and squashes the following commits: 9bdb0f35b [Sanjay Dasgupta] zepp-3522-string-default-value: Initial updates (cherry picked from commit d88a002d101ebcc407f10ac8fa345f8b5ac1f556) Signed-off-by: Jeff Zhang Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/7b0c2162 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/7b0c2162 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/7b0c2162 Branch: refs/heads/branch-0.8 Commit: 7b0c216262104488e882c74e55ffa0bdbc877915 Parents: 9631a7d Author: Sanjay Dasgupta Authored: Fri Jun 1 18:51:46 2018 +0530 Committer: Jeff Zhang Committed: Thu Jun 14 11:12:09 2018 +0800 ---------------------------------------------------------------------- cassandra/src/main/resources/interpreter-setting.json | 2 +- livy/src/main/resources/interpreter-setting.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/7b0c2162/cassandra/src/main/resources/interpreter-setting.json ---------------------------------------------------------------------- diff --git a/cassandra/src/main/resources/interpreter-setting.json b/cassandra/src/main/resources/interpreter-setting.json index 407de9c..0f0d58c 100644 --- a/cassandra/src/main/resources/interpreter-setting.json +++ b/cassandra/src/main/resources/interpreter-setting.json @@ -224,7 +224,7 @@ "cassandra.ssl.enabled": { "envName": null, "propertyName": "cassandra.ssl.enabled", - "defaultValue": "false", + "defaultValue": false, "description": "Cassandra SSL", "type": "checkbox" }, http://git-wip-us.apache.org/repos/asf/zeppelin/blob/7b0c2162/livy/src/main/resources/interpreter-setting.json ---------------------------------------------------------------------- diff --git a/livy/src/main/resources/interpreter-setting.json b/livy/src/main/resources/interpreter-setting.json index a7ce2b3..7aa61d6 100644 --- a/livy/src/main/resources/interpreter-setting.json +++ b/livy/src/main/resources/interpreter-setting.json @@ -111,13 +111,13 @@ }, "zeppelin.livy.displayAppInfo": { "propertyName": "zeppelin.livy.displayAppInfo", - "defaultValue": "true", + "defaultValue": true, "description": "Whether display app info", "type": "checkbox" }, "zeppelin.livy.restart_dead_session": { "propertyName": "zeppelin.livy.restart_dead_session", - "defaultValue": "false", + "defaultValue": false, "description": "Whether restart a dead session", "type": "checkbox" }