From commits-return-4538-archive-asf-public=cust-asf.ponee.io@zeppelin.apache.org Thu Jun 7 12:05:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 41C75180663 for ; Thu, 7 Jun 2018 12:05:04 +0200 (CEST) Received: (qmail 93967 invoked by uid 500); 7 Jun 2018 10:05:03 -0000 Mailing-List: contact commits-help@zeppelin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zeppelin.apache.org Delivered-To: mailing list commits@zeppelin.apache.org Received: (qmail 93958 invoked by uid 99); 7 Jun 2018 10:05:03 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jun 2018 10:05:03 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id F2F4BE04BC; Thu, 7 Jun 2018 10:05:02 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: prabhjyotsingh@apache.org To: commits@zeppelin.apache.org Message-Id: <0333458b5a8c4b978e6ffc3c5940bff4@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: zeppelin git commit: [ZEPPELIN-3513] Zeppelin Note Creation Failure is not shown on UI Date: Thu, 7 Jun 2018 10:05:02 +0000 (UTC) Repository: zeppelin Updated Branches: refs/heads/branch-0.8 c19b69d2b -> 9ae5de3f0 [ZEPPELIN-3513] Zeppelin Note Creation Failure is not shown on UI When creating a note from Zeppelin UI which fails due to permission denied exception, there is no failure/error message shown to a user on UI which is causing confusion. This happens only in the case when HDFS is configured as the default storage for storing notebook/config. [Bug Fix] * [ZEPPELIN-3513](https://issues.apache.org/jira/browse/ZEPPELIN-3513) * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A Author: Prabhjyot Singh Closes #3009 from prabhjyotsingh/ZEPPELIN-3513 and squashes the following commits: db0673cc1 [Prabhjyot Singh] [ZEPPELIN-3513]change FileSystemException to IOException as HDFS throws AccessControlException when extends IOException Change-Id: Iec5f556239160a67a55ccfba509c14ad3651c1bb Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/9ae5de3f Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/9ae5de3f Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/9ae5de3f Branch: refs/heads/branch-0.8 Commit: 9ae5de3f00ce2546ca31b4fa12b2f39de2cba2f2 Parents: c19b69d Author: Prabhjyot Singh Authored: Wed Jun 6 18:34:25 2018 +0530 Committer: Prabhjyot Singh Committed: Thu Jun 7 15:34:55 2018 +0530 ---------------------------------------------------------------------- .../main/java/org/apache/zeppelin/socket/NotebookServer.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/9ae5de3f/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java ---------------------------------------------------------------------- diff --git a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java index 1e1e997..b6981b2 100644 --- a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java +++ b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java @@ -30,7 +30,6 @@ import java.util.regex.Pattern; import javax.servlet.http.HttpServletRequest; import org.apache.commons.lang.StringUtils; -import org.apache.commons.vfs2.FileSystemException; import org.apache.zeppelin.conf.ZeppelinConfiguration; import org.apache.zeppelin.conf.ZeppelinConfiguration.ConfVars; import org.apache.zeppelin.display.*; @@ -1052,7 +1051,7 @@ public class NotebookServer extends WebSocketServlet note.persist(subject); addConnectionToNote(note.getId(), (NotebookSocket) conn); conn.send(serializeMessage(new Message(OP.NEW_NOTE).put("note", note))); - } catch (FileSystemException e) { + } catch (IOException e) { LOG.error("Exception from createNote", e); conn.send(serializeMessage(new Message(OP.ERROR_INFO).put("info", "Oops! There is something wrong with the notebook file system. " @@ -1846,7 +1845,7 @@ public class NotebookServer extends WebSocketServlet try { note.persist(p.getAuthenticationInfo()); return true; - } catch (FileSystemException ex) { + } catch (IOException ex) { LOG.error("Exception from run", ex); conn.send(serializeMessage(new Message(OP.ERROR_INFO).put("info", "Oops! There is something wrong with the notebook file system. "