zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zjf...@apache.org
Subject zeppelin git commit: [ZEPPELIN-3522] String "defaultValue" instead of boolean in some "interpreter-settings.json" files
Date Thu, 14 Jun 2018 03:12:01 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/master a19ec6711 -> d88a002d1


[ZEPPELIN-3522] String "defaultValue" instead of boolean in some "interpreter-settings.json"
files

### What is this PR for?
The _interpreter-settings.json_ file for each interpreter has details of each configurable
parameter for that interpreter. Each parameter also has a _defaultValue_ setting. For boolean-typed
parameters the _defaultValue_ must be set to _true_ or _false_.

But in some _interpreter-settings.json_ files, the _defaultValue_ has been set to the string
values _"true"_ or _"false"_ (the quote marks are included in the value provided).

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3522

### How should this be tested?
CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Sanjay Dasgupta <sanjay.dasgupta@gmail.com>

Closes #2998 from sanjaydasgupta/zepp-3522-string-default-value and squashes the following
commits:

9bdb0f35b [Sanjay Dasgupta] zepp-3522-string-default-value: Initial updates


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/d88a002d
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/d88a002d
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/d88a002d

Branch: refs/heads/master
Commit: d88a002d101ebcc407f10ac8fa345f8b5ac1f556
Parents: a19ec67
Author: Sanjay Dasgupta <sanjay.dasgupta@gmail.com>
Authored: Fri Jun 1 18:51:46 2018 +0530
Committer: Jeff Zhang <zjffdu@apache.org>
Committed: Thu Jun 14 11:11:57 2018 +0800

----------------------------------------------------------------------
 cassandra/src/main/resources/interpreter-setting.json | 2 +-
 livy/src/main/resources/interpreter-setting.json      | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/d88a002d/cassandra/src/main/resources/interpreter-setting.json
----------------------------------------------------------------------
diff --git a/cassandra/src/main/resources/interpreter-setting.json b/cassandra/src/main/resources/interpreter-setting.json
index 407de9c..0f0d58c 100644
--- a/cassandra/src/main/resources/interpreter-setting.json
+++ b/cassandra/src/main/resources/interpreter-setting.json
@@ -224,7 +224,7 @@
       "cassandra.ssl.enabled": {
         "envName": null,
         "propertyName": "cassandra.ssl.enabled",
-        "defaultValue": "false",
+        "defaultValue": false,
         "description": "Cassandra SSL",
         "type": "checkbox"
       },

http://git-wip-us.apache.org/repos/asf/zeppelin/blob/d88a002d/livy/src/main/resources/interpreter-setting.json
----------------------------------------------------------------------
diff --git a/livy/src/main/resources/interpreter-setting.json b/livy/src/main/resources/interpreter-setting.json
index a7ce2b3..7aa61d6 100644
--- a/livy/src/main/resources/interpreter-setting.json
+++ b/livy/src/main/resources/interpreter-setting.json
@@ -111,13 +111,13 @@
       },
       "zeppelin.livy.displayAppInfo": {
         "propertyName": "zeppelin.livy.displayAppInfo",
-        "defaultValue": "true",
+        "defaultValue": true,
         "description": "Whether display app info",
         "type": "checkbox"
       },
       "zeppelin.livy.restart_dead_session": {
         "propertyName": "zeppelin.livy.restart_dead_session",
-        "defaultValue": "false",
+        "defaultValue": false,
         "description": "Whether restart a dead session",
         "type": "checkbox"
       }


Mime
View raw message