zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From prabhjyotsi...@apache.org
Subject zeppelin git commit: [ZEPPELIN-3513] Zeppelin Note Creation Failure is not shown on UI
Date Thu, 07 Jun 2018 10:05:02 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/branch-0.8 c19b69d2b -> 9ae5de3f0


[ZEPPELIN-3513] Zeppelin Note Creation Failure is not shown on UI

When creating a note from Zeppelin UI which fails due to permission denied exception, there
is no failure/error message shown to a user on UI which is causing confusion.

This happens only in the case when HDFS is configured as the default storage for storing notebook/config.

[Bug Fix]

* [ZEPPELIN-3513](https://issues.apache.org/jira/browse/ZEPPELIN-3513)

* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A

Author: Prabhjyot Singh <prabhjyotsingh@gmail.com>

Closes #3009 from prabhjyotsingh/ZEPPELIN-3513 and squashes the following commits:

db0673cc1 [Prabhjyot Singh] [ZEPPELIN-3513]change FileSystemException to IOException as HDFS
throws AccessControlException when extends IOException

Change-Id: Iec5f556239160a67a55ccfba509c14ad3651c1bb


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/9ae5de3f
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/9ae5de3f
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/9ae5de3f

Branch: refs/heads/branch-0.8
Commit: 9ae5de3f00ce2546ca31b4fa12b2f39de2cba2f2
Parents: c19b69d
Author: Prabhjyot Singh <prabhjyotsingh@gmail.com>
Authored: Wed Jun 6 18:34:25 2018 +0530
Committer: Prabhjyot Singh <prabhjyotsingh@gmail.com>
Committed: Thu Jun 7 15:34:55 2018 +0530

----------------------------------------------------------------------
 .../main/java/org/apache/zeppelin/socket/NotebookServer.java    | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/9ae5de3f/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
----------------------------------------------------------------------
diff --git a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
index 1e1e997..b6981b2 100644
--- a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
+++ b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
@@ -30,7 +30,6 @@ import java.util.regex.Pattern;
 import javax.servlet.http.HttpServletRequest;
 
 import org.apache.commons.lang.StringUtils;
-import org.apache.commons.vfs2.FileSystemException;
 import org.apache.zeppelin.conf.ZeppelinConfiguration;
 import org.apache.zeppelin.conf.ZeppelinConfiguration.ConfVars;
 import org.apache.zeppelin.display.*;
@@ -1052,7 +1051,7 @@ public class NotebookServer extends WebSocketServlet
       note.persist(subject);
       addConnectionToNote(note.getId(), (NotebookSocket) conn);
       conn.send(serializeMessage(new Message(OP.NEW_NOTE).put("note", note)));
-    } catch (FileSystemException e) {
+    } catch (IOException e) {
       LOG.error("Exception from createNote", e);
       conn.send(serializeMessage(new Message(OP.ERROR_INFO).put("info",
           "Oops! There is something wrong with the notebook file system. "
@@ -1846,7 +1845,7 @@ public class NotebookServer extends WebSocketServlet
     try {
       note.persist(p.getAuthenticationInfo());
       return true;
-    } catch (FileSystemException ex) {
+    } catch (IOException ex) {
       LOG.error("Exception from run", ex);
       conn.send(serializeMessage(new Message(OP.ERROR_INFO).put("info",
           "Oops! There is something wrong with the notebook file system. "


Mime
View raw message