zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zjf...@apache.org
Subject zeppelin git commit: ZEPPELIN-3277. NotebookServerTest.testMakeSureNoAngularObjectBroadcastToWebsocketWhoFireTheEvent fails
Date Tue, 06 Mar 2018 04:52:39 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/master a6cd0e24c -> c77c549e3


ZEPPELIN-3277. NotebookServerTest.testMakeSureNoAngularObjectBroadcastToWebsocketWhoFireTheEvent
fails

### What is this PR for?

Trivial fix for flaky test, see the comment for details.

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3277

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <zjffdu@apache.org>

Closes #2838 from zjffdu/ZEPPELIN-3277 and squashes the following commits:

68827d7 [Jeff Zhang] ZEPPELIN-3277. NotebookServerTest.testMakeSureNoAngularObjectBroadcastToWebsocketWhoFireTheEvent
fails


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/c77c549e
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/c77c549e
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/c77c549e

Branch: refs/heads/master
Commit: c77c549e3f6bfa7b08ebc0bfaacb2bd8719c875f
Parents: a6cd0e2
Author: Jeff Zhang <zjffdu@apache.org>
Authored: Mon Mar 5 15:52:14 2018 +0800
Committer: Jeff Zhang <zjffdu@apache.org>
Committed: Tue Mar 6 12:52:33 2018 +0800

----------------------------------------------------------------------
 .../test/java/org/apache/zeppelin/socket/NotebookServerTest.java   | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/c77c549e/zeppelin-server/src/test/java/org/apache/zeppelin/socket/NotebookServerTest.java
----------------------------------------------------------------------
diff --git a/zeppelin-server/src/test/java/org/apache/zeppelin/socket/NotebookServerTest.java
b/zeppelin-server/src/test/java/org/apache/zeppelin/socket/NotebookServerTest.java
index a0cb587..0b68ca6 100644
--- a/zeppelin-server/src/test/java/org/apache/zeppelin/socket/NotebookServerTest.java
+++ b/zeppelin-server/src/test/java/org/apache/zeppelin/socket/NotebookServerTest.java
@@ -123,6 +123,8 @@ public class NotebookServerTest extends AbstractTestRestApi {
       }
       Thread.sleep(100);
     }
+    // sleep for 1 second to make sure job running thread finish to fire event. See ZEPPELIN-3277
+    Thread.sleep(1000);
 
     // add angularObject
     interpreterGroup.getAngularObjectRegistry().add("object1", "value1", note1.getId(), null);


Mime
View raw message