zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zjf...@apache.org
Subject zeppelin git commit: [ZEPPELIN-3204] FIX: cursor in paragraph editor jumps
Date Wed, 14 Feb 2018 04:37:14 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/master e89f10278 -> d4783040c


[ZEPPELIN-3204] FIX: cursor in paragraph editor jumps

### What is this PR for?
Sometimes when a user enters text in the paragraph field the lower part of the paragraph starts
to jump. This PR fixes this.

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
[ZEPPELIN-3204](https://issues.apache.org/jira/browse/ZEPPELIN-3204)

### Screenshots
![gif](https://user-images.githubusercontent.com/30798933/35732168-812f4274-0829-11e8-9fd6-45c2665f9646.gif)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Savalek <def113@mail.ru>

Closes #2762 from Savalek/ZEPPELIN-3131 and squashes the following commits:

0521e25 [Savalek] FIX: cursor in paragraph editor jumps


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/d4783040
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/d4783040
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/d4783040

Branch: refs/heads/master
Commit: d4783040c4779b99c5559c908a827c61e4b10608
Parents: e89f102
Author: Savalek <def113@mail.ru>
Authored: Fri Feb 2 12:24:33 2018 +0300
Committer: Jeff Zhang <zjffdu@apache.org>
Committed: Wed Feb 14 12:37:07 2018 +0800

----------------------------------------------------------------------
 zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/d4783040/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
index fb99e63..75a0fec 100644
--- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
+++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
@@ -1028,8 +1028,7 @@ function ParagraphCtrl ($scope, $rootScope, $route, $window, $routeParams,
$loca
   const autoAdjustEditorHeight = function (editor) {
     let height =
       editor.getSession().getScreenLength() *
-      editor.renderer.lineHeight +
-      editor.renderer.scrollBar.getWidth()
+      editor.renderer.lineHeight
 
     angular.element('#' + editor.container.id).height(height.toString() + 'px')
     editor.resize()


Mime
View raw message