zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From k..@apache.org
Subject zeppelin git commit: [ZEPPELIN-2855] The Color of Pause Icon on Job Manager Change
Date Thu, 31 Aug 2017 10:09:57 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/master e47b30a88 -> 8ee509dca


[ZEPPELIN-2855] The Color of Pause Icon on Job Manager Change

### What is this PR for?
The color of pause icon on Job Manager webpage will be changed from #3071A9 to #CD5C5C since
the color has to be the same as it on notebook page.
Please refer to http://localhost:9000/#/jobmanager if running on localhost.

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2855

### How should this be tested?
Please see below attached screenshot images.

### Screenshots (if appropriate)

Before
![before](https://user-images.githubusercontent.com/6982251/29305446-cc737c0a-81d3-11e7-98b0-a8050b93e9a0.png)

After
![after](https://user-images.githubusercontent.com/6982251/29305450-d7248838-81d3-11e7-9d6a-8c00688a0dc0.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Ryan Shin <1982sdr@hanmail.net>

Closes #2533 from SDRLurker/ZEPPELIN-2855 and squashes the following commits:

d7325c1cd [Ryan Shin] [ZEPPELIN-2855] The Color of Pause Icon on Job Manager Change


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/8ee509dc
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/8ee509dc
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/8ee509dc

Branch: refs/heads/master
Commit: 8ee509dcacf55ba82cfcc3643ba115eb3a7e5344
Parents: e47b30a
Author: Ryan Shin <1982sdr@hanmail.net>
Authored: Tue Aug 15 17:16:18 2017 +0900
Committer: 1ambda <1amb4a@gmail.com>
Committed: Thu Aug 31 19:09:52 2017 +0900

----------------------------------------------------------------------
 zeppelin-web/src/app/jobmanager/job/job.html | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/8ee509dc/zeppelin-web/src/app/jobmanager/job/job.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/jobmanager/job/job.html b/zeppelin-web/src/app/jobmanager/job/job.html
index f3d2450..1028d9e 100644
--- a/zeppelin-web/src/app/jobmanager/job/job.html
+++ b/zeppelin-web/src/app/jobmanager/job/job.html
@@ -27,7 +27,8 @@ limitations under the License.
         class="job-control-btn" tooltip-placement="left"
         uib-tooltip-html="!$ctrl.isRunning() ? 'Start All Paragraphs' : 'Stop All Paragraphs'"
         ng-click="!$ctrl.isRunning() ? $ctrl.runJob() : $ctrl.stopJob()"
-        ng-class="!$ctrl.isRunning() ? 'icon-control-play' : 'icon-control-pause'">
+        ng-class="!$ctrl.isRunning() ? 'icon-control-play' : 'icon-control-pause'"
+        ng-style="{'color': $ctrl.isRunning() ? '#CD5C5C' : '#3071A9'}">
       </span>
     </div>
     <!-- job control: end -->


Mime
View raw message