zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From k..@apache.org
Subject zeppelin git commit: [HOTFIX] fix 'checkbox' type for create iterpreter form
Date Fri, 21 Jul 2017 08:20:37 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/master 05870a96c -> d07a33326


[HOTFIX] fix 'checkbox' type for create iterpreter form

### What is this PR for?
Not visible checkboxes in form to create new interpreter.

### What type of PR is it?
Bug Fix

### Screenshots (if appropriate)
before
![before](https://user-images.githubusercontent.com/25951039/28329187-5d7520f6-6c02-11e7-9ed6-cce9808cce21.png)

after
![after](https://user-images.githubusercontent.com/25951039/28329190-615668a6-6c02-11e7-8e3f-465a5f8d6d5d.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Tinkoff DWH <tinkoff.dwh@gmail.com>

Closes #2496 from tinkoff-dwh/fix_checkbox_type and squashes the following commits:

4dbeee8d [Tinkoff DWH] fix 'checkbox' type for create iterpreter form


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/d07a3332
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/d07a3332
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/d07a3332

Branch: refs/heads/master
Commit: d07a33326c85b36fcccf2835f7c63fe4ead15b3c
Parents: 05870a9
Author: Tinkoff DWH <tinkoff.dwh@gmail.com>
Authored: Tue Jul 18 21:09:49 2017 +0500
Committer: 1ambda <1amb4a@gmail.com>
Committed: Fri Jul 21 17:20:28 2017 +0900

----------------------------------------------------------------------
 jdbc/src/main/resources/interpreter-setting.json         | 8 +++++---
 zeppelin-web/src/app/interpreter/interpreter-create.html | 2 +-
 2 files changed, 6 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/d07a3332/jdbc/src/main/resources/interpreter-setting.json
----------------------------------------------------------------------
diff --git a/jdbc/src/main/resources/interpreter-setting.json b/jdbc/src/main/resources/interpreter-setting.json
index 561719e..abbc1cf 100644
--- a/jdbc/src/main/resources/interpreter-setting.json
+++ b/jdbc/src/main/resources/interpreter-setting.json
@@ -29,7 +29,8 @@
         "envName": null,
         "propertyName": "default.completer.ttlInSeconds",
         "defaultValue": "120",
-        "description": "Time to live sql completer in seconds (-1 to update everytime, 0
to disable update)"
+        "description": "Time to live sql completer in seconds (-1 to update everytime, 0
to disable update)",
+        "type": "number"
       },
       "default.driver": {
         "envName": null,
@@ -55,8 +56,9 @@
       "default.splitQueries": {
         "envName": null,
         "propertyName": "default.splitQueries",
-        "defaultValue": "false",
-        "description": "Each query is executed apart and returns the result"
+        "defaultValue": false,
+        "description": "Each query is executed apart and returns the result",
+        "type": "checkbox"
       },
       "common.max_count": {
         "envName": null,

http://git-wip-us.apache.org/repos/asf/zeppelin/blob/d07a3332/zeppelin-web/src/app/interpreter/interpreter-create.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/interpreter/interpreter-create.html b/zeppelin-web/src/app/interpreter/interpreter-create.html
index b37f160..8bf29a9 100644
--- a/zeppelin-web/src/app/interpreter/interpreter-create.html
+++ b/zeppelin-web/src/app/interpreter/interpreter-create.html
@@ -288,7 +288,7 @@ limitations under the License.
                        type="text" msd-elastic ng-model="newInterpreterSetting.properties[key].value"
/>
                 <input ng-if="newInterpreterSetting.properties[key].type === 'password'"
                        type="password" msd-elastic ng-model="newInterpreterSetting.properties[key].value"
/>
-                <input ng-if="newInterpreterSetting.properties[key].type === 'boolean'"
+                <input ng-if="newInterpreterSetting.properties[key].type === 'checkbox'"
                        type="checkbox" msd-elastic ng-model="newInterpreterSetting.properties[key].value"
/>
               </td>
               <td style="vertical-align: middle;">


Mime
View raw message