zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m...@apache.org
Subject zeppelin git commit: [ZEPPELIN-2473] ZeppelinRestApiTest fails on travis
Date Thu, 08 Jun 2017 18:12:58 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/master 32d8afaff -> 427d9d494


[ZEPPELIN-2473] ZeppelinRestApiTest fails on travis

### What is this PR for?
The test `testNoteCreateWithParagraphs`  fails with a `java.lang.NullPointerException`. The
error occurs while getting the value of 'mode' from the Map graph. Added a fix to get the
value correctly.

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2473

### How should this be tested?
Tests should pass on the CI

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: pravin-dsilva <pravind@us.ibm.com>

Closes #2400 from pravin-dsilva/ZEPPELIN-2473 and squashes the following commits:

c8ce19c [pravin-dsilva] ZEPPELIN-2473 - ZeppelinRestApiTest fails on travis
803d5ce [pravin-dsilva] Update .travis.yml to include ZeppelinRestApiTest


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/427d9d49
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/427d9d49
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/427d9d49

Branch: refs/heads/master
Commit: 427d9d494d286ef7161224b7c0a23bd2066591ce
Parents: 32d8afa
Author: pravin-dsilva <pravind@us.ibm.com>
Authored: Wed Jun 7 05:55:13 2017 +0000
Committer: Lee moon soo <moon@apache.org>
Committed: Thu Jun 8 11:12:55 2017 -0700

----------------------------------------------------------------------
 .travis.yml                                                       | 3 +--
 .../test/java/org/apache/zeppelin/rest/ZeppelinRestApiTest.java   | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/427d9d49/.travis.yml
----------------------------------------------------------------------
diff --git a/.travis.yml b/.travis.yml
index c8d3aa8..5a728f7 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -49,10 +49,9 @@ matrix:
     #
     # Several tests were excluded from this configuration due to the following issues:
     # HeliumApplicationFactoryTest - https://issues.apache.org/jira/browse/ZEPPELIN-2470
-    # ZeppelinRestApiTest          - https://issues.apache.org/jira/browse/ZEPPELIN-2473
     # After issues are fixed these tests need to be included back by removing them from the
"-Dtests.to.exclude" property
     - jdk: "oraclejdk7"
-      env: SCALA_VER="2.11" SPARK_VER="2.1.0" HADOOP_VER="2.6" PROFILE="-Pweb-ci -Pscalding
-Phelium-dev -Pexamples -Pscala-2.11" BUILD_FLAG="package -Pbuild-distr -DskipRat" TEST_FLAG="verify
-Pusing-packaged-distr -DskipRat" MODULES="-pl ${INTERPRETERS}" TEST_PROJECTS="-Dtests.to.exclude=**/ZeppelinSparkClusterTest.java,**/org.apache.zeppelin.spark.*,**/HeliumApplicationFactoryTest.java,**/ZeppelinRestApiTest.java
-DfailIfNoTests=false"
+      env: SCALA_VER="2.11" SPARK_VER="2.1.0" HADOOP_VER="2.6" PROFILE="-Pweb-ci -Pscalding
-Phelium-dev -Pexamples -Pscala-2.11" BUILD_FLAG="package -Pbuild-distr -DskipRat" TEST_FLAG="verify
-Pusing-packaged-distr -DskipRat" MODULES="-pl ${INTERPRETERS}" TEST_PROJECTS="-Dtests.to.exclude=**/ZeppelinSparkClusterTest.java,**/org.apache.zeppelin.spark.*,**/HeliumApplicationFactoryTest.java
-DfailIfNoTests=false"
 
     # Test selenium with spark module for 1.6.3
     - jdk: "oraclejdk7"

http://git-wip-us.apache.org/repos/asf/zeppelin/blob/427d9d49/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinRestApiTest.java
----------------------------------------------------------------------
diff --git a/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinRestApiTest.java
b/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinRestApiTest.java
index 4ee5a00..5093cb8 100644
--- a/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinRestApiTest.java
+++ b/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinRestApiTest.java
@@ -167,7 +167,7 @@ public class ZeppelinRestApiTest extends AbstractTestRestApi {
         assertEquals("paragraph col width check failed", 9.0, p.getConfig().get("colWidth"));
         assertTrue("paragraph show title check failed", ((boolean) p.getConfig().get("title")));
         Map graph = ((List<Map>)p.getConfig().get("results")).get(0);
-        String mode = graph.get("mode").toString();
+        String mode = ((Map)graph.get("graph")).get("mode").toString();
         assertEquals("paragraph graph mode check failed", "pieChart", mode);
       }
     }


Mime
View raw message