zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m...@apache.org
Subject zeppelin git commit: [ZEPPELIN-2544] clean task doesn't work in zeppelin-web
Date Sun, 28 May 2017 00:32:05 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/master c70f29b2c -> cc0839efd


[ZEPPELIN-2544] clean task doesn't work in zeppelin-web

### What is this PR for?

`prebuild` task in package.json doesn't work for `build:*` tasks in zeppelin-web

otherwise we will get overwritten result, if previous build for zeppelin-web failed like

```
[INFO] Running "cacheBust:taskName" (cacheBust) task
[INFO] Warning: Unable to write "/Users/jl/local/src/g/zeppelin/zeppelin-web/dist/styles/vendor.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.css"
file (Error code: ENAMETOOLONG). Use --force to continue.
```

### What type of PR is it?
[Bug Fix]

### Todos

DONE

### What is the Jira issue?

[ZEPPELIN-2544](https://issues.apache.org/jira/browse/ZEPPELIN-2544)

### How should this be tested?

- `cd zeppelin-web`
- `npm run build:dist`

Then, check the console output whether `prebuild` is applied or not.

### Screenshots (if appropriate)

```
## Before

$ zeppelin-web git:(ZEPPELIN-2544/prebuild-does-not-work) npm run build:dist

> zeppelin-web0.0.0 build:dist /Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web
> grunt pre-webpack-dist && webpack && grunt post-webpack-dist

## After

zeppelin-web git:(ZEPPELIN-2544/prebuild-does-not-work) ✗ npm run build:dist

> zeppelin-web0.0.0 build:dist /Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web
> npm-run-all prebuild && grunt pre-webpack-dist && webpack &&
grunt post-webpack-dist
```

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO

Author: 1ambda <1amb4a@gmail.com>

Closes #2351 from 1ambda/ZEPPELIN-2544/prebuild-does-not-work and squashes the following commits:

47d4f87 [1ambda] fix: Use prebuild in pcakage.json


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/cc0839ef
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/cc0839ef
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/cc0839ef

Branch: refs/heads/master
Commit: cc0839efdec69173831ea72358a4829c5b8ba658
Parents: c70f29b
Author: 1ambda <1amb4a@gmail.com>
Authored: Fri May 19 01:15:27 2017 +0900
Committer: Lee moon soo <moon@apache.org>
Committed: Sun May 28 09:31:59 2017 +0900

----------------------------------------------------------------------
 zeppelin-web/package.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/cc0839ef/zeppelin-web/package.json
----------------------------------------------------------------------
diff --git a/zeppelin-web/package.json b/zeppelin-web/package.json
index 74e3d4d..b6685b0 100644
--- a/zeppelin-web/package.json
+++ b/zeppelin-web/package.json
@@ -9,8 +9,8 @@
     "clean": "rimraf dist && rimraf .tmp",
     "postinstall": "bower install --silent",
     "prebuild": "npm-run-all clean lint:once",
-    "build:dist": "grunt pre-webpack-dist && webpack && grunt post-webpack-dist",
-    "build:ci": "grunt pre-webpack-ci && webpack && grunt post-webpack-dist",
+    "build:dist": "npm-run-all prebuild && grunt pre-webpack-dist && webpack
&& grunt post-webpack-dist",
+    "build:ci": "npm-run-all prebuild && grunt pre-webpack-ci && webpack
&& grunt post-webpack-dist",
     "lint:watch": "esw --watch src",
     "lint:once": "eslint src",
     "predev": "grunt pre-webpack-dev",


Mime
View raw message