zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m...@apache.org
Subject zeppelin git commit: [ZEPPELIN-2469] HeliumBundleFactoryTest fails on Travis
Date Thu, 25 May 2017 06:39:03 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/master a1c5e99a5 -> 9af85d8cc


[ZEPPELIN-2469] HeliumBundleFactoryTest fails on Travis

### What is this PR for?
There are 6 errors occuring with error: "yarn config set cache-folder /tmp/ZeppelinLTest_1494573109020/helium-bundle/yarn-cache
--registry=http://registry.npmjs.org/' failed."
The failures seem to occur because the "yarnCacheDir" directory is not created. For this,
I have added code to create the directory before the absolute path is stored in yarnCacheDirPath.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2469

### How should this be tested?
The tests should pass on the CI

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: pravin-dsilva <pravind@us.ibm.com>

Closes #2362 from pravin-dsilva/ZEPPELIN-2469 and squashes the following commits:

19fd231 [pravin-dsilva] update travis.yml
1939013 [pravin-dsilva] [ZEPPELIN-2469] HeliumBundleFactoryTest fails on Travis


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/9af85d8c
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/9af85d8c
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/9af85d8c

Branch: refs/heads/master
Commit: 9af85d8ccff184891c42302ba63239189ae663ab
Parents: a1c5e99
Author: pravin-dsilva <pravind@us.ibm.com>
Authored: Mon May 22 11:39:19 2017 +0000
Committer: Lee moon soo <moon@apache.org>
Committed: Thu May 25 15:38:59 2017 +0900

----------------------------------------------------------------------
 .travis.yml                                                       | 3 +--
 .../main/java/org/apache/zeppelin/helium/HeliumBundleFactory.java | 1 +
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/9af85d8c/.travis.yml
----------------------------------------------------------------------
diff --git a/.travis.yml b/.travis.yml
index d6887ef..5135ce7 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -48,13 +48,12 @@ matrix:
     # Test core modules
     #
     # Several tests were excluded from this configuration due to the following issues:
-    # HeliumBundleFactoryTest      - https://issues.apache.org/jira/browse/ZEPPELIN-2469
     # HeliumApplicationFactoryTest - https://issues.apache.org/jira/browse/ZEPPELIN-2470
     # NotebookTest                 - https://issues.apache.org/jira/browse/ZEPPELIN-2471
     # ZeppelinRestApiTest          - https://issues.apache.org/jira/browse/ZEPPELIN-2473
     # After issues are fixed these tests need to be included back by removing them from the
"-Dtests.to.exclude" property
     - jdk: "oraclejdk7"
-      env: SCALA_VER="2.11" SPARK_VER="2.1.0" HADOOP_VER="2.6" PROFILE="-Pweb-ci -Pscalding
-Phelium-dev -Pexamples -Pscala-2.11" BUILD_FLAG="package -Pbuild-distr -DskipRat" TEST_FLAG="verify
-Pusing-packaged-distr -DskipRat" MODULES="-pl ${INTERPRETERS}" TEST_PROJECTS="-Dtests.to.exclude=**/ZeppelinSparkClusterTest.java,**/org.apache.zeppelin.spark.*,**/HeliumBundleFactoryTest.java,**/HeliumApplicationFactoryTest.java,**/NotebookTest.java,**/ZeppelinRestApiTest.java
-DfailIfNoTests=false"
+      env: SCALA_VER="2.11" SPARK_VER="2.1.0" HADOOP_VER="2.6" PROFILE="-Pweb-ci -Pscalding
-Phelium-dev -Pexamples -Pscala-2.11" BUILD_FLAG="package -Pbuild-distr -DskipRat" TEST_FLAG="verify
-Pusing-packaged-distr -DskipRat" MODULES="-pl ${INTERPRETERS}" TEST_PROJECTS="-Dtests.to.exclude=**/ZeppelinSparkClusterTest.java,**/org.apache.zeppelin.spark.*,**/HeliumApplicationFactoryTest.java,**/NotebookTest.java,**/ZeppelinRestApiTest.java
-DfailIfNoTests=false"
 
     # Test selenium with spark module for 1.6.3
     - jdk: "oraclejdk7"

http://git-wip-us.apache.org/repos/asf/zeppelin/blob/9af85d8c/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumBundleFactory.java
----------------------------------------------------------------------
diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumBundleFactory.java
b/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumBundleFactory.java
index bf2804e..ef032bd 100644
--- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumBundleFactory.java
+++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumBundleFactory.java
@@ -129,6 +129,7 @@ public class HeliumBundleFactory {
       YarnInstaller yarnInstaller = frontEndPluginFactory.getYarnInstaller(getProxyConfig());
       yarnInstaller.setYarnVersion(YARN_VERSION);
       yarnInstaller.install();
+      yarnCacheDir.mkdirs();
       String yarnCacheDirPath = yarnCacheDir.getAbsolutePath();
       yarnCommand(frontEndPluginFactory, "config set cache-folder " + yarnCacheDirPath);
 


Mime
View raw message