zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloverhea...@apache.org
Subject zeppelin git commit: [branch-0.7] missed try catch.
Date Sun, 21 May 2017 14:22:12 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/branch-0.7 95bf6172b -> c9b0db772


[branch-0.7] missed try catch.

### What is this PR for?
Currently we can not build on branch-0.7
The cause is a missed try catch.
So, I fixed this part.

### What type of PR is it?
Hot Fix

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: CloverHearts <cloverheartsdev@gmail.com>

Closes #2353 from cloverhearts/missing-try-catch and squashes the following commits:

8a9ea5ce [CloverHearts] missing try catch


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/c9b0db77
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/c9b0db77
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/c9b0db77

Branch: refs/heads/branch-0.7
Commit: c9b0db7724d17a80bf1723a73502610ea7716c8e
Parents: 95bf617
Author: CloverHearts <cloverheartsdev@gmail.com>
Authored: Fri May 19 19:24:31 2017 +0900
Committer: CloverHearts <cloverheartsdev@gmail.com>
Committed: Sun May 21 23:21:47 2017 +0900

----------------------------------------------------------------------
 .../src/main/java/org/apache/zeppelin/notebook/Notebook.java   | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/c9b0db77/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java
----------------------------------------------------------------------
diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java
index 1885594..953a73f 100644
--- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java
+++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java
@@ -338,7 +338,11 @@ public class Notebook implements NoteEventListener {
       note = notes.remove(id);
       folders.removeNote(note);
     }
-    interpreterSettingManager.removeNoteInterpreterSettingBinding(subject.getUser(), id);
+    try {
+      interpreterSettingManager.removeNoteInterpreterSettingBinding(subject.getUser(), id);
+    } catch (IOException e) {
+      logger.error(e.toString(), e);
+    }
     noteSearchService.deleteIndexDocs(note);
     notebookAuthorization.removeNote(id);
 


Mime
View raw message