zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From prabhjyotsi...@apache.org
Subject zeppelin git commit: ZEPPELIN-2530: Zeppelin user impersonation with domain name suffix is failing
Date Tue, 16 May 2017 07:33:55 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/master 2afa9cbd5 -> 07a5b15d1


ZEPPELIN-2530: Zeppelin user impersonation with domain name suffix is failing

### What is this PR for?
Basically what happens is, if a user login using full name with suffix then the user impersonation
fails, as the HDFS expects username without the suffix.
This is because the username is passed to underlying components with suffix and got rejected
in security layer with IllegalArgumentException

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
* [ZEPPELIN-2530](https://issues.apache.org/jira/browse/ZEPPELIN-2530)

### How should this be tested?
 - Enable AD authentication
 - set `activeDirectoryRealm.principalSuffix` in shiro.ini
 - now try to login with the full user name (in my example its zepplintestdomain.com)

### Screenshots (if appropriate)

Before:
<img width="1439" alt="screen shot 2017-05-11 at 7 01 24 pm" src="https://cloud.githubusercontent.com/assets/674497/25951758/44d8adda-367c-11e7-82c1-ecbe2737e13a.png">

After:
<img width="1440" alt="screen shot 2017-05-11 at 7 00 47 pm" src="https://cloud.githubusercontent.com/assets/674497/25951766/47fbc470-367c-11e7-8d14-31465a4db8bf.png">

### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a

Author: Prabhjyot Singh <prabhjyotsingh@gmail.com>

Closes #2337 from prabhjyotsingh/ZEPPELIN-2530 and squashes the following commits:

f135eb4bb [Prabhjyot Singh] validate user string for null/empty before sending it to AD server
5a02759a1 [Prabhjyot Singh] ZEPPELIN-2530: Zeppelin user impersonation with domain name suffix
is failing


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/07a5b15d
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/07a5b15d
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/07a5b15d

Branch: refs/heads/master
Commit: 07a5b15d1677e157a253a195c99f6a7926c2532a
Parents: 2afa9cb
Author: Prabhjyot Singh <prabhjyotsingh@gmail.com>
Authored: Fri May 12 09:10:33 2017 +0530
Committer: Prabhjyot Singh <prabhjyotsingh@gmail.com>
Committed: Tue May 16 13:03:43 2017 +0530

----------------------------------------------------------------------
 .../realm/ActiveDirectoryGroupRealm.java         | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/07a5b15d/zeppelin-server/src/main/java/org/apache/zeppelin/realm/ActiveDirectoryGroupRealm.java
----------------------------------------------------------------------
diff --git a/zeppelin-server/src/main/java/org/apache/zeppelin/realm/ActiveDirectoryGroupRealm.java
b/zeppelin-server/src/main/java/org/apache/zeppelin/realm/ActiveDirectoryGroupRealm.java
index 8a9d66b..d40a643 100644
--- a/zeppelin-server/src/main/java/org/apache/zeppelin/realm/ActiveDirectoryGroupRealm.java
+++ b/zeppelin-server/src/main/java/org/apache/zeppelin/realm/ActiveDirectoryGroupRealm.java
@@ -186,7 +186,7 @@ public class ActiveDirectoryGroupRealm extends AbstractLdapRealm {
     LdapContext ctx = null;
     try {
       String userPrincipalName = upToken.getUsername();
-      if (userPrincipalName == null) {
+      if (!isValidPrincipalName(userPrincipalName)) {
         return null;
       }
       if (this.principalSuffix != null && userPrincipalName.indexOf('@') < 0)
{
@@ -201,7 +201,24 @@ public class ActiveDirectoryGroupRealm extends AbstractLdapRealm {
     return buildAuthenticationInfo(upToken.getUsername(), upToken.getPassword());
   }
 
+  private Boolean isValidPrincipalName(String userPrincipalName) {
+    if (userPrincipalName != null) {
+      if (StringUtils.isNotEmpty(userPrincipalName) && userPrincipalName.contains("@"))
{
+        String userPrincipalWithoutDomain = userPrincipalName.split("@")[0].trim();
+        if (StringUtils.isNotEmpty(userPrincipalWithoutDomain)) {
+          return true;
+        }
+      } else if (StringUtils.isNotEmpty(userPrincipalName)) {
+        return true;
+      }
+    }
+    return false;
+  }
+
   protected AuthenticationInfo buildAuthenticationInfo(String username, char[] password)
{
+    if (this.principalSuffix != null && username.indexOf('@') > 1) {
+      username = username.split("@")[0];
+    }
     return new SimpleAuthenticationInfo(username, password, getName());
   }
 


Mime
View raw message