zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m...@apache.org
Subject zeppelin git commit: [ZEPPELIN-2479] Fix incorrect tooltip view inside of version control menu
Date Fri, 05 May 2017 18:26:45 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/branch-0.7 a6e33e136 -> 08c1c9fe9


[ZEPPELIN-2479] Fix incorrect tooltip view inside of version control menu

This is to fix incorrect appearance of tooltip inside version control menu

Improvement

* [x] - fix/remove tooltip

[ZEPPELIN-2479](https://issues.apache.org/jira/browse/ZEPPELIN-2479)

go to `version control` menu in notebook action bar of note

before:
<img width="689" alt="screen shot 2017-05-02 at 3 32 23 pm" src="https://cloud.githubusercontent.com/assets/1642088/25606467/62f0901c-2f4c-11e7-95ef-c22f1df410be.png">

after:
![screen shot 2017-05-02 at 6 55 24 pm](https://cloud.githubusercontent.com/assets/1642088/25613839/aac216a4-2f6a-11e7-8cab-a77ddb48382b.png)

* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Khalid Huseynov <khalidhnv@gmail.com>

Closes #2306 from khalidhuseynov/fix/ZEPPELIN-2479 and squashes the following commits:

ac4e651 [Khalid Huseynov] add css class

(cherry picked from commit 8e96d8bd7b6e1a01df004800c526d316725a2b62)
Signed-off-by: Lee moon soo <moon@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/08c1c9fe
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/08c1c9fe
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/08c1c9fe

Branch: refs/heads/branch-0.7
Commit: 08c1c9fe9f0642f18fe28a668434473042bdf96b
Parents: a6e33e1
Author: Khalid Huseynov <khalidhnv@gmail.com>
Authored: Tue May 2 18:45:11 2017 +0900
Committer: Lee moon soo <moon@apache.org>
Committed: Fri May 5 14:26:31 2017 -0400

----------------------------------------------------------------------
 zeppelin-web/src/app/notebook/notebook-actionBar.html | 2 ++
 zeppelin-web/src/app/notebook/notebook.css            | 5 ++++-
 2 files changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/08c1c9fe/zeppelin-web/src/app/notebook/notebook-actionBar.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/notebook-actionBar.html b/zeppelin-web/src/app/notebook/notebook-actionBar.html
index c90c120..71ad299 100644
--- a/zeppelin-web/src/app/notebook/notebook-actionBar.html
+++ b/zeppelin-web/src/app/notebook/notebook-actionBar.html
@@ -130,6 +130,8 @@ limitations under the License.
                         ng-hide="viewOnly"
                         ng-click="checkpointNote(note.checkpoint.message)"
                         style="margin-left: 4px;"
+                        tooltip-append-to-body="true"
+                        tooltip-class="revisionTooltip"
                         tooltip-placement="bottom" uib-tooltip="Commit this note">Commit
                 </button>
               </div>

http://git-wip-us.apache.org/repos/asf/zeppelin/blob/08c1c9fe/zeppelin-web/src/app/notebook/notebook.css
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/notebook.css b/zeppelin-web/src/app/notebook/notebook.css
index 8c48528..6e189f8 100644
--- a/zeppelin-web/src/app/notebook/notebook.css
+++ b/zeppelin-web/src/app/notebook/notebook.css
@@ -51,6 +51,10 @@
   border-color: #ccc;
 }
 
+.revisionTooltip {
+  z-index: 10003;
+}
+
 .caretSeparator {
   height: 22px;
   line-height: 9px;
@@ -313,7 +317,6 @@
   max-width: 50%;
 }
 
-
 .inactivelink {
   color: darkgrey;
   cursor: default;


Mime
View raw message