zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m...@apache.org
Subject zeppelin git commit: [ZEPPELIN-2348] Line chart setting is not rendered (branch-0.7)
Date Tue, 04 Apr 2017 19:39:52 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/branch-0.7 ac3c5f40c -> 4021520f7


[ZEPPELIN-2348] Line chart setting is not rendered (branch-0.7)

### What is this PR for?

Line chart setting is not rendered.

### What type of PR is it?
[Bug Fix]

### Todos

None.

### What is the Jira issue?

[ZEPPELIN-2348](https://issues.apache.org/jira/browse/ZEPPELIN-2348)

### How should this be tested?

1. Open the default line chart's setting
2. Check checkboxes for options.

### Screenshots (if appropriate)

#### After

![image](https://cloud.githubusercontent.com/assets/4968473/24643544/ad22b336-1949-11e7-95c4-5a5ba17f1d1b.png)

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO

Author: 1ambda <1amb4a@gmail.com>

Closes #2219 from 1ambda/ZEPPELIN-2348/line-chart-setting and squashes the following commits:

4216587 [1ambda] fix: overwriting trSetting


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/4021520f
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/4021520f
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/4021520f

Branch: refs/heads/branch-0.7
Commit: 4021520f782d026915eac565b77e8954f73df52c
Parents: ac3c5f4
Author: 1ambda <1amb4a@gmail.com>
Authored: Tue Apr 4 15:44:28 2017 +0900
Committer: Lee moon soo <moon@apache.org>
Committed: Wed Apr 5 04:39:47 2017 +0900

----------------------------------------------------------------------
 .../src/app/notebook/paragraph/result/result.controller.js         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/4021520f/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js b/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
index 9b95b40..e7026f7 100644
--- a/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
+++ b/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
@@ -456,7 +456,7 @@ function ResultCtrl($scope, $rootScope, $route, $window, $routeParams,
$location
         var retryRenderer = function() {
           var targetEl = angular.element('#p' + $scope.id + '_' + type);
           var transformationSettingTargetEl = angular.element('#trsetting' + $scope.id +
'_' + type);
-          var visualizationSettingTargetEl = angular.element('#trsetting' + $scope.id + '_'
+ type);
+          var visualizationSettingTargetEl = angular.element('#vizsetting' + $scope.id +
'_' + type);
           if (targetEl.length) {
             var config = getVizConfig(type);
             targetEl.height(height);


Mime
View raw message