zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahyoung...@apache.org
Subject zeppelin git commit: [HOTFIX] Invalid method signature in GroovyInterpreter
Date Mon, 17 Apr 2017 07:31:29 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/master be2020123 -> f32651e51


[HOTFIX] Invalid method signature in GroovyInterpreter

### What is this PR for?

- https://github.com/apache/zeppelin/pull/2203 was merged
- but https://github.com/apache/zeppelin/pull/2203 was not rebased recently
- as a result, `GroovyInterperter` has invalid method signature.

```
[ERROR] COMPILATION ERROR :
[ERROR] /home/travis/build/1ambda/zeppelin/groovy/src/main/java/org/apache/zeppelin/groovy/GroovyInterpreter.java:[123,3]
method does not override or implement a method from a supertype
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile
(default-compile) on project zeppelin-groovy: Compilation failure
[ERROR] /home/travis/build/1ambda/zeppelin/groovy/src/main/java/org/apache/zeppelin/groovy/GroovyInterpreter.java:[123,3]
method does not override or implement a method from a supertype
```

You can see CI failures in

- https://travis-ci.org/1ambda/zeppelin/jobs/222709988
- https://travis-ci.org/1ambda/zeppelin/jobs/222709989

### What type of PR is it?
[Hot Fix]

### Todos

NONE

### What is the Jira issue?

Hotfix

### How should this be tested?

- CI should be green.
- Build this PR locally, `mvn clean package -DskipTests;`

### Screenshots (if appropriate)

NONE

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO

Author: 1ambda <1amb4a@gmail.com>

Closes #2255 from 1ambda/HOTFIX/GroovyInterpreter-has-invalid-overrided-method and squashes
the following commits:

29e840f [1ambda] fix: Method signature in GroovyInterpreter


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/f32651e5
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/f32651e5
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/f32651e5

Branch: refs/heads/master
Commit: f32651e519a27d755cdbed5f008d6d5f242695a2
Parents: be20201
Author: 1ambda <1amb4a@gmail.com>
Authored: Mon Apr 17 15:24:20 2017 +0900
Committer: ahyoungryu <ahyoungryu@apache.org>
Committed: Mon Apr 17 16:31:23 2017 +0900

----------------------------------------------------------------------
 .../main/java/org/apache/zeppelin/groovy/GroovyInterpreter.java   | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/f32651e5/groovy/src/main/java/org/apache/zeppelin/groovy/GroovyInterpreter.java
----------------------------------------------------------------------
diff --git a/groovy/src/main/java/org/apache/zeppelin/groovy/GroovyInterpreter.java b/groovy/src/main/java/org/apache/zeppelin/groovy/GroovyInterpreter.java
index 8951a62..e108283 100644
--- a/groovy/src/main/java/org/apache/zeppelin/groovy/GroovyInterpreter.java
+++ b/groovy/src/main/java/org/apache/zeppelin/groovy/GroovyInterpreter.java
@@ -121,7 +121,8 @@ public class GroovyInterpreter extends Interpreter {
   }
 
   @Override
-  public List<InterpreterCompletion> completion(String buf, int cursor) {
+  public List<InterpreterCompletion> completion(String buf, int cursor,
+                                                InterpreterContext interpreterContext) {
     return null;
   }
 


Mime
View raw message