zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m...@apache.org
Subject zeppelin git commit: fix bugs for timer saver
Date Wed, 12 Apr 2017 23:29:34 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/branch-0.7 6955c8d8a -> d4cacadaf


fix bugs for timer saver

### What is this PR for?

* add saveNote action when cron schedule setting in  file notebook.controller.js
   * case:
  open one note,edit some text in a paragraph, then do a cron schedule setting, the content
which   just edited disappeared

* change invoke method for the timer saver  in file paragraph.controller.js
  * case:
   open one browser,edit some text in a paragraph, then open the note in  other browser,you
will find that the text you just edited did not be synced

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
[ZEPPELIN-2323](https://issues.apache.org/jira/browse/ZEPPELIN-2323)

### How should this be tested?
Outline the steps to test the PR here.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?

Author: LeiWang <wanglei6744@163.com>
Author: lei wang <lei1989@outlook.com>

Closes #2196 from wary/master and squashes the following commits:

b2ee2f9 [LeiWang] Update notebook.controller.js
2ab58c3 [LeiWang] Update notebook.controller.js
9908227 [LeiWang] Update paragraph.controller.js
3612f56 [lei wang] fix bugs for timer saver

(cherry picked from commit 902892a97723b0c4deb4ef832588067a0faa9d74)
Signed-off-by: Lee moon soo <moon@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/d4cacada
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/d4cacada
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/d4cacada

Branch: refs/heads/branch-0.7
Commit: d4cacadaf25bec969f6facb48694ce65265b97dc
Parents: 6955c8d
Author: LeiWang <wanglei6744@163.com>
Authored: Sun Apr 9 19:01:46 2017 +0800
Committer: Lee moon soo <moon@apache.org>
Committed: Thu Apr 13 08:29:29 2017 +0900

----------------------------------------------------------------------
 .../src/app/notebook/paragraph/paragraph.controller.js       | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/d4cacada/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
index 5e1d5c5..47d34c6 100644
--- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
+++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
@@ -125,15 +125,15 @@ function ParagraphCtrl($scope, $rootScope, $route, $window, $routeParams,
$locat
 
   var initializeDefault = function(config) {
     var forms = $scope.paragraph.settings.forms;
-    
+
     if (!config.colWidth) {
       config.colWidth = 12;
     }
-  
+
     if (config.enabled === undefined) {
       config.enabled = true;
     }
-  
+
     for (var idx in forms) {
       if (forms[idx]) {
         if (forms[idx].options) {
@@ -472,7 +472,7 @@ function ParagraphCtrl($scope, $rootScope, $route, $window, $routeParams,
$locat
     var session = editor.getSession();
     var dirtyText = session.getValue();
     $scope.dirtyText = dirtyText;
-    $scope.$broadcast('startSaveTimer');
+    $scope.startSaveTimer();
     setParagraphMode(session, dirtyText, editor.getCursorPosition());
   };
 


Mime
View raw message