zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jongy...@apache.org
Subject zeppelin git commit: [ZEPPELIN-2124] Missing dependencies array in interpreter.json after upgrade from 0.6.2 to 0.7.0
Date Thu, 16 Mar 2017 15:00:43 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/branch-0.7 adf2b12e9 -> 56fa8b534


[ZEPPELIN-2124] Missing dependencies array in interpreter.json after upgrade from 0.6.2 to
0.7.0

### What is this PR for?
If there is no `dependencies` field specified in `interpreter.json`, front-end throws error
because it tries to push new element to undefined variable. This PR fixes this issue by setting
initial value of `dependencies` to empty array.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
[ZEPPELIN-2124](https://issues.apache.org/jira/browse/ZEPPELIN-2124)

### How should this be tested?
Remove `dependencies` field from `conf/interpreter.json` and try to add new dependencies in
http://localhost:8080/#/interpreter page.

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Mina Lee <minalee@apache.org>

Closes #2142 from minahlee/ZEPPELIN-2124 and squashes the following commits:

01b27eb [Mina Lee] Assign init value for dependencies field

(cherry picked from commit f9a8a6f6e8e9959b5bed0a69723b934a25b7f261)
Signed-off-by: Jongyoul Lee <jongyoul@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/56fa8b53
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/56fa8b53
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/56fa8b53

Branch: refs/heads/branch-0.7
Commit: 56fa8b5349fa6889fa4d5097497bef7282a7c647
Parents: adf2b12
Author: Mina Lee <minalee@apache.org>
Authored: Thu Mar 16 10:57:38 2017 +0900
Committer: Jongyoul Lee <jongyoul@apache.org>
Committed: Fri Mar 17 00:00:37 2017 +0900

----------------------------------------------------------------------
 .../java/org/apache/zeppelin/interpreter/InterpreterSetting.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/56fa8b53/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java
----------------------------------------------------------------------
diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java
b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java
index 57c6acc..30a4967 100644
--- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java
+++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java
@@ -65,7 +65,7 @@ public class InterpreterSetting {
   @SerializedName("interpreterGroup")
   private List<InterpreterInfo> interpreterInfos;
   private final transient Map<String, InterpreterGroup> interpreterGroupRef = new HashMap<>();
-  private List<Dependency> dependencies;
+  private List<Dependency> dependencies = new LinkedList<>();
   private InterpreterOption option;
   private transient String path;
 


Mime
View raw message