zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mina...@apache.org
Subject zeppelin git commit: [ZEPPELIN-2026] Flaky Test: WebDriverManager.getWebDriver() fails with Unable to locate element 'WebSocket Connected'
Date Wed, 01 Feb 2017 01:11:11 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/branch-0.7 13705e0b8 -> ab806e0ce


[ZEPPELIN-2026] Flaky Test: WebDriverManager.getWebDriver() fails with Unable to locate element
'WebSocket Connected'

### What is this PR for?
Selenium test sometimes fails with

```
Caused by: org.openqa.selenium.NoSuchElementException: Unable to locate element: {"method":"xpath","selector":"//i[tooltip='WebSocket
Connected']"}
```

This PR gives enough timeout (30s) for waiting 'WebSocket Connected' element.

Tested in my travis account 5 times and they're all green.
https://travis-ci.org/Leemoonsoo/zeppelin/builds/196428795
https://travis-ci.org/Leemoonsoo/zeppelin/builds/196429337
https://travis-ci.org/Leemoonsoo/zeppelin/builds/196429559
https://travis-ci.org/Leemoonsoo/zeppelin/builds/196429593
https://travis-ci.org/Leemoonsoo/zeppelin/builds/196430020

However, I'm not 100% sure if it really fixes the flaky test.
So, I'd like to merge this PR but keep ZEPPELIN-2026 open for next 1 week.
And then see if no selenium test fails with the error for next 1 week to close ZEPPELIN-2026.

### What type of PR is it?
Improvement

### Todos
* [x] - Increase timeout of detecting 'connected'

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2026

### How should this be tested?
CI green on Selenium test profile

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <moon@apache.org>

Closes #1959 from Leemoonsoo/ZEPPELIN-2026 and squashes the following commits:

87432d5 [Lee moon soo] increase timeout

(cherry picked from commit 7ccfdf705d3fd79590ec5d9fb7ba0b48e285ed84)
Signed-off-by: Mina Lee <minalee@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/ab806e0c
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/ab806e0c
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/ab806e0c

Branch: refs/heads/branch-0.7
Commit: ab806e0ce7f5fc162d8e90074e03dd994419a8eb
Parents: 13705e0
Author: Lee moon soo <moon@apache.org>
Authored: Mon Jan 30 06:56:28 2017 +0900
Committer: Mina Lee <minalee@apache.org>
Committed: Wed Feb 1 10:10:58 2017 +0900

----------------------------------------------------------------------
 .../src/test/java/org/apache/zeppelin/WebDriverManager.java        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/ab806e0c/zeppelin-server/src/test/java/org/apache/zeppelin/WebDriverManager.java
----------------------------------------------------------------------
diff --git a/zeppelin-server/src/test/java/org/apache/zeppelin/WebDriverManager.java b/zeppelin-server/src/test/java/org/apache/zeppelin/WebDriverManager.java
index 41bd1b0..e8cc4cc 100644
--- a/zeppelin-server/src/test/java/org/apache/zeppelin/WebDriverManager.java
+++ b/zeppelin-server/src/test/java/org/apache/zeppelin/WebDriverManager.java
@@ -122,7 +122,7 @@ public class WebDriverManager {
     while (System.currentTimeMillis() - start < 60 * 1000) {
       // wait for page load
       try {
-        (new WebDriverWait(driver, 5)).until(new ExpectedCondition<Boolean>() {
+        (new WebDriverWait(driver, 30)).until(new ExpectedCondition<Boolean>() {
           @Override
           public Boolean apply(WebDriver d) {
             return d.findElement(By.xpath("//i[@tooltip='WebSocket Connected']"))


Mime
View raw message