zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jongy...@apache.org
Subject zeppelin git commit: [ZEPPELIN-1551] Remove the "default" text against interpreters on interpreters screen as it is providing incorrect semantics
Date Tue, 07 Feb 2017 15:11:33 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/branch-0.7 bb1b29cb6 -> dc14599c9

[ZEPPELIN-1551] Remove the "default" text against interpreters on interpreters screen as it
is providing incorrect semantics

### What is this PR for?
This PR addresses the incorrect semantics and confusion caused by the "default" text against
an interpreter group on interpreters page.
The intent of of this tag seems to be informing the user which of the interpreters among a
particular group will be used by default if the user doesn't specify any %<interpreter>
tag. However, the "default" tag is always tied to the first interpreter of the first interpreter
group on the page and isn't displayed for any other interpreter groups; therefore not serving
any purpose. It also leads to confusion with the default interpreter bound to a notebook on
bindings page.

It would be better to remove this default tag from interpreters in order to avoid the confusion.

### What type of PR is it?
Bug Fix

### Todos

### What is the Jira issue?

### How should this be tested?
Run Zeppelin server. Open Interpreters menu. "default" shouldn't be visible against any interpreter

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

### Screenshots (if appropriate)

Author: Naman Mishra <namanm@qubole.com>

Closes #1968 from namanmishra91/ZEPPELIN-1551 and squashes the following commits:

f9ded1d [Naman Mishra] Remove the "default" text against interpreters on interpreter settings
screen as it is providing incorrect semantics.

(cherry picked from commit 82fc4ba258d1c212533d11e9c700864e36ae2f87)
Signed-off-by: Jongyoul Lee <jongyoul@apache.org>

Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/dc14599c
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/dc14599c
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/dc14599c

Branch: refs/heads/branch-0.7
Commit: dc14599c9ed7ebe06f9e8d4d175168f379856c58
Parents: bb1b29c
Author: Naman Mishra <namanm@qubole.com>
Authored: Thu Feb 2 16:28:50 2017 +0530
Committer: Jongyoul Lee <jongyoul@apache.org>
Committed: Wed Feb 8 00:11:28 2017 +0900

 zeppelin-web/src/app/interpreter/interpreter.html | 1 -
 1 file changed, 1 deletion(-)

diff --git a/zeppelin-web/src/app/interpreter/interpreter.html b/zeppelin-web/src/app/interpreter/interpreter.html
index ed1aa2d..c586814 100644
--- a/zeppelin-web/src/app/interpreter/interpreter.html
+++ b/zeppelin-web/src/app/interpreter/interpreter.html
@@ -103,7 +103,6 @@ limitations under the License.
               %<span ng-show="!$parent.$first || $first">{{setting.name}}</span
               ><span ng-show="(!$parent.$first || $first) && !$first">.</span
               ><span ng-show="!$first">{{interpreter.name}}</span>
-              <span ng-show="$parent.$first && $first">(default)</span>

View raw message