Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3FFF1200C0D for ; Tue, 17 Jan 2017 06:50:56 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3EFD6160B4D; Tue, 17 Jan 2017 05:50:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8997A160B41 for ; Tue, 17 Jan 2017 06:50:55 +0100 (CET) Received: (qmail 94345 invoked by uid 500); 17 Jan 2017 05:50:54 -0000 Mailing-List: contact commits-help@zeppelin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zeppelin.apache.org Delivered-To: mailing list commits@zeppelin.apache.org Received: (qmail 94335 invoked by uid 99); 17 Jan 2017 05:50:54 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jan 2017 05:50:54 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5703ADFBFF; Tue, 17 Jan 2017 05:50:54 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: ahyoungryu@apache.org To: commits@zeppelin.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: zeppelin git commit: [Hot Fix] Fix deadlink in writingzeppelinvisualization.md Date: Tue, 17 Jan 2017 05:50:54 +0000 (UTC) archived-at: Tue, 17 Jan 2017 05:50:56 -0000 Repository: zeppelin Updated Branches: refs/heads/master 2fcfaa8c7 -> 425abe302 [Hot Fix] Fix deadlink in writingzeppelinvisualization.md ### What is this PR for? It should point [HeliumVisualizationFactory.java](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumVisualizationFactory.java) not [HeliumVisualizationPackage.java](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumVisualizationPackage.java) ### What type of PR is it? Documentation | HotFix ### What is the Jira issue? N/A ### How should this be tested? click `HeliumVisualizationFactory` link in [this section](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/development/writingzeppelinvisualization.html#3-create-and-load-visualization-bundle-on-the-fly) :) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu Closes #1904 from AhyoungRyu/fix/deadlink and squashes the following commits: 60ac6c9 [AhyoungRyu] Fix deadlink in writingzeppelinvisualization.md Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/425abe30 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/425abe30 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/425abe30 Branch: refs/heads/master Commit: 425abe302374522278e7e76d4c78b71ce5dcdd9d Parents: 2fcfaa8 Author: AhyoungRyu Authored: Mon Jan 16 22:30:21 2017 +0900 Committer: ahyoungryu Committed: Tue Jan 17 14:50:46 2017 +0900 ---------------------------------------------------------------------- docs/development/writingzeppelinvisualization.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/425abe30/docs/development/writingzeppelinvisualization.md ---------------------------------------------------------------------- diff --git a/docs/development/writingzeppelinvisualization.md b/docs/development/writingzeppelinvisualization.md index 364bb08..ab46958 100644 --- a/docs/development/writingzeppelinvisualization.md +++ b/docs/development/writingzeppelinvisualization.md @@ -61,7 +61,7 @@ Click 'enable' button. #### 3. Create and load visualization bundle on the fly -Once a Visualization package is enabled, [HeliumVisualizationFactory](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumVisualizationPackage.java) creates a js bundle. The js bundle is served by `helium/visualization/load` rest api endpoint. +Once a Visualization package is enabled, [HeliumVisualizationFactory](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumVisualizationFactory.java) creates a js bundle. The js bundle is served by `helium/visualization/load` rest api endpoint. #### 4. Run visualization