zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mina...@apache.org
Subject zeppelin git commit: [ZEPPELIN-2000] Run paragraph on enter when select dynamic form value changed
Date Tue, 24 Jan 2017 00:59:38 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/master e49fb47de -> 7b7625db1


[ZEPPELIN-2000] Run paragraph on enter when select dynamic form value changed

### What is this PR for?
Run paragraph on enter when select dynamic form value changed to make paragraph runnable in
report mode.

### What type of PR is it?
Bug Fix | Hot Fix

### What is the Jira issue?
[ZEPPELIN-2000](https://issues.apache.org/jira/browse/ZEPPELIN-2000)

### How should this be tested?
1. Go to `Zeppelin Tutorial/Basic Features (Spark)` notebook
2. Change view mode to `report`.
3. Change selected value from `married` to `single` in 5th paragraph and hit enter.
4. See if paragraph runs

### Screenshots (if appropriate)
![jan-23-2017 14-14-05](https://cloud.githubusercontent.com/assets/8503346/22192310/460d713c-e176-11e6-96d4-96d25eb029c0.gif)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes. docs update included.

Author: Mina Lee <minalee@apache.org>

Closes #1932 from minahlee/ZEPPELIN-2000 and squashes the following commits:

a9f02d2 [Mina Lee] Update docs
66b513c [Mina Lee] Run paragraph onEnter when select value changed


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/7b7625db
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/7b7625db
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/7b7625db

Branch: refs/heads/master
Commit: 7b7625db10eb6b0c49d58375b09d0dead9f4912d
Parents: e49fb47
Author: Mina Lee <minalee@apache.org>
Authored: Mon Jan 23 14:08:38 2017 +0900
Committer: Mina Lee <minalee@apache.org>
Committed: Tue Jan 24 09:59:21 2017 +0900

----------------------------------------------------------------------
 docs/manual/dynamicform.md                                         | 2 ++
 .../app/notebook/paragraph/paragraph-parameterizedQueryForm.html   | 1 +
 2 files changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/7b7625db/docs/manual/dynamicform.md
----------------------------------------------------------------------
diff --git a/docs/manual/dynamicform.md b/docs/manual/dynamicform.md
index e0adb4c..12f51a9 100644
--- a/docs/manual/dynamicform.md
+++ b/docs/manual/dynamicform.md
@@ -56,6 +56,8 @@ Also you can separate option's display name and value, using `${formName=default
 
 <img src="../assets/themes/zeppelin/img/screenshots/form_select_displayname.png" />
 
+Hit enter after selecting option to run the paragraph with new value.
+
 ### Checkbox form
 
 For multi-selection, you can create a checkbox form using `${checkbox:formName=defaultValue1|defaultValue2...,option1|option2...}`.
The variable will be substituted by a comma-separated string based on the selected items.
For example:

http://git-wip-us.apache.org/repos/asf/zeppelin/blob/7b7625db/zeppelin-web/src/app/notebook/paragraph/paragraph-parameterizedQueryForm.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph-parameterizedQueryForm.html
b/zeppelin-web/src/app/notebook/paragraph/paragraph-parameterizedQueryForm.html
index 6108054..117e11c 100644
--- a/zeppelin-web/src/app/notebook/paragraph/paragraph-parameterizedQueryForm.html
+++ b/zeppelin-web/src/app/notebook/paragraph/paragraph-parameterizedQueryForm.html
@@ -29,6 +29,7 @@ limitations under the License.
 
       <select class="form-control input-sm"
              ng-if="paragraph.settings.forms[formulaire.name].options && paragraph.settings.forms[formulaire.name].type
!= 'checkbox'"
+             ng-enter="runParagraph(getEditorValue())"
              ng-model="paragraph.settings.params[formulaire.name]"
              ng-class="{'disable': paragraph.status == 'RUNNING' || paragraph.status == 'PENDING'
}"
              name="{{formulaire.name}}"


Mime
View raw message