zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jongy...@apache.org
Subject zeppelin git commit: [MINOR][ZEPPELIN-1919] Reduce markdown intp's plain text font size
Date Sun, 08 Jan 2017 15:16:40 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/master 3a12f3032 -> 24ca17b7d


[MINOR][ZEPPELIN-1919] Reduce markdown intp's plain text font size

### What is this PR for?
Currently Zeppelin `%md` result style is using [`github-markdown-css`](https://github.com/sindresorhus/github-markdown-css).
But the plain text's font-size a bit bigger than any other interpreter's. And the margin between
the text paragraph is also wider than before. So I reduced them.

### What type of PR is it?
Improvement

### What is the Jira issue?
[ZEPPELIN-1919](https://issues.apache.org/jira/browse/ZEPPELIN-1919)

### How should this be tested?
 - After applying this patch, run dev mode under `zeppelin-web` \w `npm run dev`
 - Compare the font size using `%md` interpreter

### Screenshots (if appropriate)
 - Before
![before](https://cloud.githubusercontent.com/assets/10060731/21746484/116d9986-d58a-11e6-878c-40b84c488020.png)

 - After
![after](https://cloud.githubusercontent.com/assets/10060731/21746486/16ff6514-d58a-11e6-9800-3b0193dcc694.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: AhyoungRyu <fbdkdud93@hanmail.net>

Closes #1867 from AhyoungRyu/overwrite/github-markdown-css and squashes the following commits:

f910b04 [AhyoungRyu] Down size markdown intp's plain text font


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/24ca17b7
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/24ca17b7
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/24ca17b7

Branch: refs/heads/master
Commit: 24ca17b7df6e63833ebe6e008baacc0f63541275
Parents: 3a12f30
Author: AhyoungRyu <fbdkdud93@hanmail.net>
Authored: Sat Jan 7 21:06:23 2017 +0900
Committer: Jongyoul Lee <jongyoul@apache.org>
Committed: Mon Jan 9 00:16:27 2017 +0900

----------------------------------------------------------------------
 .../src/app/notebook/paragraph/paragraph.css    | 32 +++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/24ca17b7/zeppelin-web/src/app/notebook/paragraph/paragraph.css
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.css b/zeppelin-web/src/app/notebook/paragraph/paragraph.css
index 9fa09fb..b2a9045 100644
--- a/zeppelin-web/src/app/notebook/paragraph/paragraph.css
+++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.css
@@ -478,7 +478,7 @@ table.dataTable.table-condensed .sorting_desc:after {
 }
 
 /*
-  Paragaph Font CSS
+  Paragraph Font CSS
 */
 
 .lightBold {
@@ -561,3 +561,33 @@ table.table-striped {
 .changeTypeMenu li:hover {
   background: #eee;
 }
+
+/*
+  Overwrite github-markdown-css for Markdown interpreter
+*/
+
+.markdown-body h1,
+.markdown-body h2,
+.markdown-body h3,
+.markdown-body h4,
+.markdown-body h5,
+.markdown-body h6 {
+  margin-top: 16px;
+  margin-bottom: 16px;
+}
+
+.markdown-body {
+  font-size: 14px;
+}
+
+.markdown-body h2 {
+  font-size: 26px;
+}
+
+.markdown-body h3 {
+  font-size: 20px;
+}
+
+.markdown-body h4 {
+  font-size: 16px;
+}


Mime
View raw message