zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahyoung...@apache.org
Subject zeppelin git commit: [HOTFIX][ZEPPELIN-1970] Use relative path for broken screenshot imgs
Date Sun, 15 Jan 2017 14:34:00 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/branch-0.7 8dc4721ea -> 8956d682f


[HOTFIX][ZEPPELIN-1970] Use relative path for broken screenshot imgs

### What is this PR for?
Two screenshot imgs in [Writing a new visualization](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/development/writingzeppelinvisualization.html)
page are broken after deployed. It can be fixed by using relative path like other images.
(e.g. [shiroauthentication.md](https://github.com/apache/zeppelin/blob/master/docs/security/shiroauthentication.md#4-login))

### What type of PR is it?
Hot Fix

### What is the Jira issue?
[ZEPPELIN-1970](https://issues.apache.org/jira/browse/ZEPPELIN-1970)

### How should this be tested?
It can't be reproduced using docs dev mode. Needs to be tested with below steps.

```
1) build gh-pages (website) branch
JEKYLL_ENV=production bundle exec jekyll build
cp -r _site/ /tmp/zeppelin_website/
mkdir -p /tmp/zeppelin_website/docs/0.7.0-SNAPSHOT

2) build this patch (docs) and copy it under docs/0.7.0-SNAPSHOT of website
cd docs
bundle exec jekyll build --safe
cp -r _site/ /tmp/zeppelin_website/0.7.0-SNAPSHOT/

3) start httpserver and browse http://localhost:8000/docs/0.7.0-SNAPSHOT/
cd /tmp/zeppelin_website
python -m SimpleHTTPServer
```

### Screenshots (if appropriate)
 - before
<img width="809" alt="screen shot 2017-01-15 at 3 10 53 pm" src="https://cloud.githubusercontent.com/assets/10060731/21960655/a73ee658-db35-11e6-8e4d-7702adb1ab19.png">

 - after
<img width="751" alt="screen shot 2017-01-15 at 3 10 13 pm" src="https://cloud.githubusercontent.com/assets/10060731/21960650/a23348a2-db35-11e6-80a4-a6bc9b9b188c.png">

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: AhyoungRyu <fbdkdud93@hanmail.net>

Closes #1901 from AhyoungRyu/ZEPPELIN-1970 and squashes the following commits:

d64e13f [AhyoungRyu] Use relative path for screenshot imgs

(cherry picked from commit f86bb858b8032408b542f15ccb8794df02224a33)
Signed-off-by: ahyoungryu <ahyoungryu@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/8956d682
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/8956d682
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/8956d682

Branch: refs/heads/branch-0.7
Commit: 8956d682f591062cd129b93be23b3a10e91dcc83
Parents: 8dc4721
Author: AhyoungRyu <fbdkdud93@hanmail.net>
Authored: Sun Jan 15 15:14:42 2017 +0900
Committer: ahyoungryu <ahyoungryu@apache.org>
Committed: Sun Jan 15 23:33:45 2017 +0900

----------------------------------------------------------------------
 docs/development/writingzeppelinvisualization.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/8956d682/docs/development/writingzeppelinvisualization.md
----------------------------------------------------------------------
diff --git a/docs/development/writingzeppelinvisualization.md b/docs/development/writingzeppelinvisualization.md
index d7c2268..364bb08 100644
--- a/docs/development/writingzeppelinvisualization.md
+++ b/docs/development/writingzeppelinvisualization.md
@@ -56,7 +56,7 @@ Once Zeppelin loads _Helium package files_ from local registry, available
packag
 
 Click 'enable' button.
 
-<img class="img-responsive" style="width:70%" src="/assets/themes/zeppelin/img/docs-img/writing_visualization_helium_menu.png"
/>
+<img class="img-responsive" style="width:70%" src="../assets/themes/zeppelin/img/docs-img/writing_visualization_helium_menu.png"
/>
 
 
 #### 3. Create and load visualization bundle on the fly
@@ -69,7 +69,7 @@ Once a Visualization package is enabled, [HeliumVisualizationFactory](https://gi
 Zeppelin shows additional button for loaded Visualizations.
 User can use just like any other built-in visualizations.
 
-<img class="img-responsive" style="width:70%" src="/assets/themes/zeppelin/img/docs-img/writing_visualization_example.png"
/>
+<img class="img-responsive" style="width:70%" src="../assets/themes/zeppelin/img/docs-img/writing_visualization_example.png"
/>
 
 
 


Mime
View raw message