zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahyoung...@apache.org
Subject zeppelin git commit: [MINOR] Add markdown escaping to find missing parts
Date Fri, 18 Nov 2016 17:01:06 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/master a99cef9d4 -> f4dc39061


[MINOR] Add markdown escaping to find missing parts

### What is this PR for?
Currently `{{note.id}}>{{noteName(note)}}` is not shown in `notebookashomepage.md`. So
I added markdown escaping for this.

### What type of PR is it?
Documentation

### What is the Jira issue?
no Jira issue for this

### How should this be tested?
Please see the below screenshot imgs :)

### Screenshots (if appropriate)
 - Before
<img width="797" alt="screen shot 2016-11-15 at 9 22 15 am" src="https://cloud.githubusercontent.com/assets/10060731/20298331/9b2e8828-ab15-11e6-9010-50df6100a961.png">

 - After
![picture1](https://cloud.githubusercontent.com/assets/10060731/20298335/9f55a2c4-ab15-11e6-99e3-ac83a76a2ff6.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: AhyoungRyu <fbdkdud93@hanmail.net>

Closes #1634 from AhyoungRyu/add-markdown-escaping and squashes the following commits:

34a4bc7 [AhyoungRyu] Add markdown escaping to find some missing parts


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/f4dc3906
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/f4dc3906
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/f4dc3906

Branch: refs/heads/master
Commit: f4dc3906195d6040da01d1e08787f4e1495bd537
Parents: a99cef9
Author: AhyoungRyu <fbdkdud93@hanmail.net>
Authored: Tue Nov 15 09:20:53 2016 +0100
Committer: ahyoungryu <ahyoungryu@apache.org>
Committed: Fri Nov 18 18:00:21 2016 +0100

----------------------------------------------------------------------
 docs/manual/notebookashomepage.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/f4dc3906/docs/manual/notebookashomepage.md
----------------------------------------------------------------------
diff --git a/docs/manual/notebookashomepage.md b/docs/manual/notebookashomepage.md
index 729f324..a82d100 100644
--- a/docs/manual/notebookashomepage.md
+++ b/docs/manual/notebookashomepage.md
@@ -81,7 +81,7 @@ println(
         <i style="font-size: 15px;" class="icon-notebook"></i> Create new note</a></h5>
         <ul style="list-style-type: none;">
           <li ng-repeat="note in home.notes.list track by $index"><i style="font-size:
10px;" class="icon-doc"></i>
-            <a style="text-decoration: none;" href="#/notebook/{{note.id}}">{{noteName(note)}}</a>
+            <a style="text-decoration: none;" href="#/notebook/{{"{{note.id"}}}}>{{"{{noteName(note)"}}}}</a>
           </li>
         </ul>
     </div>


Mime
View raw message