zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahyoung...@apache.org
Subject zeppelin git commit: Enable to search interpreters only based on the name
Date Fri, 18 Nov 2016 17:30:26 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/master f4dc39061 -> 3eae4e071


Enable to search interpreters only based on the name

### What is this PR for?
Currently when you're trying to search some interpreters, for example "Spark", the page shows
both "Livy" and "Spark". It's because Livy contains Spark related properties such as `livy.spark.driver.cores`,
`livy.spark.driver.memory` and etc etc. As an user aspect, I felt a bit uncomfortable with
this.
So I added one more condition so that it can search only based on interpreter name.

### What type of PR is it?
Improvement

### What is the Jira issue?
no Jira issue for this

### How should this be tested?
Outline the steps to test the PR here.

### Screenshots (if appropriate)
 - Before
![before](https://cloud.githubusercontent.com/assets/10060731/20309013/a20c60f8-ab46-11e6-9b68-bf3980de3b6b.gif)

 - After
![after](https://cloud.githubusercontent.com/assets/10060731/20309017/a4376300-ab46-11e6-92c9-a8b6a674f312.gif)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: AhyoungRyu <fbdkdud93@hanmail.net>

Closes #1640 from AhyoungRyu/search-basedOn-name and squashes the following commits:

7564e1c [AhyoungRyu] Search interpreter only based on interpreter name


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/3eae4e07
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/3eae4e07
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/3eae4e07

Branch: refs/heads/master
Commit: 3eae4e0711924721db49b4e3b840282ca987a80c
Parents: f4dc390
Author: AhyoungRyu <fbdkdud93@hanmail.net>
Authored: Tue Nov 15 15:15:42 2016 +0100
Committer: ahyoungryu <ahyoungryu@apache.org>
Committed: Fri Nov 18 18:30:19 2016 +0100

----------------------------------------------------------------------
 zeppelin-web/src/app/interpreter/interpreter.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/3eae4e07/zeppelin-web/src/app/interpreter/interpreter.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/interpreter/interpreter.html b/zeppelin-web/src/app/interpreter/interpreter.html
index e91dabe..a33127f 100644
--- a/zeppelin-web/src/app/interpreter/interpreter.html
+++ b/zeppelin-web/src/app/interpreter/interpreter.html
@@ -90,7 +90,7 @@ limitations under the License.
 </div>
 
 <div class="box width-full"
-     ng-repeat="setting in interpreterSettings | orderBy: 'name' | filter: searchInterpreter"
interpreter-directive>
+     ng-repeat="setting in interpreterSettings | orderBy: 'name' | filter: {name:searchInterpreter}
" interpreter-directive>
   <div id="{{setting.name | lowercase}}">
     <div class="row interpreter">
 


Mime
View raw message