Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AB11E200BAB for ; Sat, 22 Oct 2016 17:33:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A9712160AE0; Sat, 22 Oct 2016 15:33:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7A371160ADB for ; Sat, 22 Oct 2016 17:33:58 +0200 (CEST) Received: (qmail 63117 invoked by uid 500); 22 Oct 2016 15:33:57 -0000 Mailing-List: contact commits-help@zeppelin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zeppelin.apache.org Delivered-To: mailing list commits@zeppelin.apache.org Received: (qmail 63108 invoked by uid 99); 22 Oct 2016 15:33:57 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Oct 2016 15:33:57 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 62F85E0209; Sat, 22 Oct 2016 15:33:57 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: jongyoul@apache.org To: commits@zeppelin.apache.org Message-Id: <5829bd80479e40c4b1ae1b487abfc6fa@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: zeppelin git commit: [ Hotfix ] Incorrect (per user) setup ui for "create new interpreter component" Date: Sat, 22 Oct 2016 15:33:57 +0000 (UTC) archived-at: Sat, 22 Oct 2016 15:33:59 -0000 Repository: zeppelin Updated Branches: refs/heads/master 9e9ea3aea -> 8af7856fd [ Hotfix ] Incorrect (per user) setup ui for "create new interpreter component" ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html ### What type of PR is it? Bug Fix ### Todos - [x] fix to text margin top - [x] implement to (per note / per user) setup feature of create new insterpreter ### How should this be tested? 1. on click interpreter menu. 2. on click interpreter menu. 3. check per user and per note setting. (`per user` setting must be shiro is activated) 4. save and check to result. ### Screenshots (if appropriate) #### - Create new Interpreter - before ![pernotebefore](https://cloud.githubusercontent.com/assets/10525473/19588103/6d1236a4-979e-11e6-972b-bb6d35f83ac5.png) #### - Create new Interpreter - after ![new create interpreter](https://cloud.githubusercontent.com/assets/10525473/19588118/87ad23ca-979e-11e6-9a2b-4ec8be27c74f.png) #### - fix margin for interpreter settings - before ![pernotebefore](https://cloud.githubusercontent.com/assets/10525473/19588140/a8b701ee-979e-11e6-804b-4e39c063281d.png) #### - fix margin for interpreter settings - after ![margin](https://cloud.githubusercontent.com/assets/10525473/19588145/b13ca8f0-979e-11e6-9a02-186b92a0dad1.png) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: CloverHearts Closes #1546 from cloverhearts/hotfix-inerpreterRunningModeUIFix and squashes the following commits: ebf1d81 [CloverHearts] hotfix - change setup ui for interpreter setting components Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/8af7856f Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/8af7856f Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/8af7856f Branch: refs/heads/master Commit: 8af7856fd1b36da1c059cbd8eb71d6b28f0cd23e Parents: 9e9ea3a Author: CloverHearts Authored: Fri Oct 21 14:40:01 2016 +0900 Committer: Jongyoul Lee Committed: Sun Oct 23 00:33:42 2016 +0900 ---------------------------------------------------------------------- .../interpreter-create/interpreter-create.html | 196 +++++++++++++++---- .../src/app/interpreter/interpreter.html | 104 +++++----- 2 files changed, 210 insertions(+), 90 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/8af7856f/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html b/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html index 2638dd8..9013aab 100644 --- a/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html +++ b/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html @@ -37,45 +37,165 @@ limitations under the License.
Option
- - - - - - - - - - -
+
+
+ The interpreter will be instantiated + + + + + in + + + + + process. + + + + + +
+
+   +
+
+
+
+ + + And + + + + in + + + + + process. + + +
+
+
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/8af7856f/zeppelin-web/src/app/interpreter/interpreter.html ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/interpreter/interpreter.html b/zeppelin-web/src/app/interpreter/interpreter.html index e0e8613..ce716d5 100644 --- a/zeppelin-web/src/app/interpreter/interpreter.html +++ b/zeppelin-web/src/app/interpreter/interpreter.html @@ -250,62 +250,62 @@ limitations under the License.  
-
-
- - - - And - - - - in - - - - - process. - + + in + + + + process. +
-
-   -