zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mina...@apache.org
Subject zeppelin git commit: [ZEPPELIN-1534] Does not load dependency library when creating new interpreter.
Date Wed, 19 Oct 2016 00:44:14 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/master 1214463c6 -> abf0470a3


[ZEPPELIN-1534] Does not load dependency library when creating new interpreter.

### What is this PR for?
This PR fixes dependency library loading bug when creating new interpreter.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1534

### How should this be tested?
1. Create new JDBC interpreter refer to http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/interpreter/jdbc.html#mysql.
2. Create new paragraph for testing new JDBC interpreter.
3. Run paragraph.

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: astroshim <hsshim@nflabs.com>

Closes #1507 from astroshim/ZEPPELIN-1534 and squashes the following commits:

aebe352 [astroshim] add loadInterpreterDependencies function in createNewSetting()


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/abf0470a
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/abf0470a
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/abf0470a

Branch: refs/heads/master
Commit: abf0470a3c8f3f7d38bc96c345f72f3298243f5c
Parents: 1214463
Author: astroshim <hsshim@nflabs.com>
Authored: Tue Oct 11 23:04:27 2016 +0900
Committer: Mina Lee <minalee@apache.org>
Committed: Wed Oct 19 09:44:08 2016 +0900

----------------------------------------------------------------------
 .../java/org/apache/zeppelin/interpreter/InterpreterFactory.java    | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/abf0470a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java
----------------------------------------------------------------------
diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java
b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java
index 494361b..5d9f301 100644
--- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java
+++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java
@@ -596,6 +596,7 @@ public class InterpreterFactory implements InterpreterGroupFactory {
     setting.setProperties(p);
     setting.setInterpreterGroupFactory(this);
     interpreterSettings.put(setting.getId(), setting);
+    loadInterpreterDependencies(setting);
     saveToFile();
     return setting;
   }


Mime
View raw message