zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jongy...@apache.org
Subject zeppelin git commit: [MINOR] Changed guava version to 19.0 for selenium test
Date Mon, 20 Jun 2016 09:46:03 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/master 7fd9a6600 -> 8790ba97c


[MINOR] Changed guava version to 19.0 for selenium test

### What is this PR for?
Enable selenium test with SafariDriver.

### What type of PR is it?
[Bug Fix]

### Todos
* [x] - Upgrade guava version

### What is the Jira issue?
N/A

### How should this be tested?
1. Install selenium driver for Safari
1. Make sure that you don't have firefox installed
1. Start Zeppelin without this patch
1. run a selenium test. `TEST_SELENIUM="true" mvn package -DfailIfNoTests=false -pl 'zeppelin-interpreter,zeppelin-zengine,zeppelin-server'
-Dtest=ParagraphActionsIT`
1. Got error
1. Repeat after patch
1. Success

### Screenshots (if appropriate)
Got error like:
```
java.lang.NoSuchMethodError: com.google.common.util.concurrent.MoreExecutors.directExecutor()Ljava/util/concurrent/Executor;
	at org.openqa.selenium.safari.WebSocketConnection.send(WebSocketConnection.java:139)
	at org.openqa.selenium.safari.SafariDriverCommandExecutor.execute(SafariDriverCommandExecutor.java:188)
	at org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:620)
	at org.openqa.selenium.remote.RemoteWebDriver.startSession(RemoteWebDriver.java:247)
	at org.openqa.selenium.remote.RemoteWebDriver.<init>(RemoteWebDriver.java:129)
	at org.openqa.selenium.remote.RemoteWebDriver.<init>(RemoteWebDriver.java:142)
	at org.openqa.selenium.safari.SafariDriver.<init>(SafariDriver.java:62)
	at org.openqa.selenium.safari.SafariDriver.<init>(SafariDriver.java:42)
	at org.apache.zeppelin.WebDriverManager.getWebDriver(WebDriverManager.java:103)
	at org.apache.zeppelin.integration.ParagraphActionsIT.startUp(ParagraphActionsIT.java:51)
```

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jongyoul Lee <jongyoul@gmail.com>

Closes #1035 from jongyoul/minor-upgrade-guava-for-selenium-with-safaridriver and squashes
the following commits:

6f93278 [Jongyoul Lee] Changed guava version to 19.0


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/8790ba97
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/8790ba97
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/8790ba97

Branch: refs/heads/master
Commit: 8790ba97caf0a08f7d73a3dec6b583f572f18189
Parents: 7fd9a66
Author: Jongyoul Lee <jongyoul@gmail.com>
Authored: Fri Jun 17 17:33:49 2016 +0900
Committer: Jongyoul Lee <jongyoul@apache.org>
Committed: Mon Jun 20 18:45:52 2016 +0900

----------------------------------------------------------------------
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/8790ba97/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 0d4abc5..a035c6d 100755
--- a/pom.xml
+++ b/pom.xml
@@ -94,7 +94,7 @@
     <log4j.version>1.2.17</log4j.version>
     <libthrift.version>0.9.2</libthrift.version>
     <gson.version>2.2</gson.version>
-    <guava.version>15.0</guava.version>
+    <guava.version>19.0</guava.version>
     <jetty.version>9.2.15.v20160210</jetty.version>
 
     <PermGen>64m</PermGen>


Mime
View raw message