zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jongy...@apache.org
Subject zeppelin git commit: [HOTFIX] Fixed PythonInterpreterTest
Date Thu, 23 Jun 2016 17:53:15 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/master f27020447 -> 74346a22b


[HOTFIX] Fixed PythonInterpreterTest

### What is this PR for?
Returning back to pass the CI

### What type of PR is it?
[Hot Fix]

### Todos
* [x] - Fix test cases

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1048

### How should this be tested?

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jongyoul Lee <jongyoul@gmail.com>

Closes #1073 from jongyoul/hotfix-fix-pythoninterpretertest and squashes the following commits:

32be5d1 [Jongyoul Lee] Fixed test failed


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/74346a22
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/74346a22
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/74346a22

Branch: refs/heads/master
Commit: 74346a22b12b249b9c3be0c890042b7c48bc67b9
Parents: f270204
Author: Jongyoul Lee <jongyoul@gmail.com>
Authored: Fri Jun 24 02:28:10 2016 +0900
Committer: Jongyoul Lee <jongyoul@apache.org>
Committed: Fri Jun 24 02:53:11 2016 +0900

----------------------------------------------------------------------
 .../org/apache/zeppelin/python/PythonInterpreterTest.java    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/74346a22/python/src/test/java/org/apache/zeppelin/python/PythonInterpreterTest.java
----------------------------------------------------------------------
diff --git a/python/src/test/java/org/apache/zeppelin/python/PythonInterpreterTest.java b/python/src/test/java/org/apache/zeppelin/python/PythonInterpreterTest.java
index dbd1346..c0bc293 100644
--- a/python/src/test/java/org/apache/zeppelin/python/PythonInterpreterTest.java
+++ b/python/src/test/java/org/apache/zeppelin/python/PythonInterpreterTest.java
@@ -114,9 +114,9 @@ public class PythonInterpreterTest {
     assertNull(pythonInterpreter.getPy4jPort());
 
     assertTrue(cmdHistory.contains("def help()"));
-    assertTrue(cmdHistory.contains("class PyZeppelinContext():"));
+    assertTrue(cmdHistory.contains("class PyZeppelinContext(object):"));
     assertTrue(cmdHistory.contains("z = PyZeppelinContext"));
-    assertTrue(cmdHistory.contains("def zeppelin_show"));
+    assertTrue(cmdHistory.contains("z.show"));
     assertFalse(cmdHistory.contains("GatewayClient"));
 
   }
@@ -140,9 +140,9 @@ public class PythonInterpreterTest {
     assertNotNull(py4jPort);
 
     assertTrue(cmdHistory.contains("def help()"));
-    assertTrue(cmdHistory.contains("class PyZeppelinContext():"));
+    assertTrue(cmdHistory.contains("class PyZeppelinContext(object):"));
     assertTrue(cmdHistory.contains("z = PyZeppelinContext"));
-    assertTrue(cmdHistory.contains("def zeppelin_show"));
+    assertTrue(cmdHistory.contains("z.show"));
     assertTrue(cmdHistory.contains("GatewayClient(port=" + py4jPort + ")"));
     assertTrue(cmdHistory.contains("org.apache.zeppelin.display.Input"));
 


Mime
View raw message