zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From prabhjyotsi...@apache.org
Subject zeppelin git commit: [HOTFIX] Fix flaky AuthenticationIT
Date Sat, 25 Jun 2016 03:36:19 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/master f55290f49 -> 510cecd38


[HOTFIX] Fix flaky AuthenticationIT

### What is this PR for?

This is hotfix for CI failing for

Tests in error:
  AuthenticationIT.testGroupPermission:177->authenticationUser:109->AbstractZeppelinIT.pollingWait:114
» Timeout

### What type of PR is it?
[Hot Fix]

### Todos
* [x] -  Add check for request.status === 500, while logout

### What is the Jira issue?
 - [ZEPPELIN-1009](https://issues.apache.org/jira/browse/ZEPPELIN-1009)

### How should this be tested?
Check for CI green

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a

Author: Prabhjyot Singh <prabhjyotsingh@gmail.com>

Closes #1084 from prabhjyotsingh/hotfix/testGroupPermission and squashes the following commits:

50b479b [Prabhjyot Singh] check for request.status === 500


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/510cecd3
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/510cecd3
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/510cecd3

Branch: refs/heads/master
Commit: 510cecd3896f1d9b0551f7f2d5ecd5f3db655427
Parents: f55290f
Author: Prabhjyot Singh <prabhjyotsingh@gmail.com>
Authored: Sat Jun 25 08:31:50 2016 +0530
Committer: Prabhjyot Singh <prabhjyotsingh@gmail.com>
Committed: Sat Jun 25 09:06:05 2016 +0530

----------------------------------------------------------------------
 zeppelin-web/src/components/navbar/navbar.controller.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/510cecd3/zeppelin-web/src/components/navbar/navbar.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/components/navbar/navbar.controller.js b/zeppelin-web/src/components/navbar/navbar.controller.js
index 31e595e..1620934 100644
--- a/zeppelin-web/src/components/navbar/navbar.controller.js
+++ b/zeppelin-web/src/components/navbar/navbar.controller.js
@@ -92,7 +92,7 @@ angular.module('zeppelinWebApp')
     request.open('post', logoutURL, true, 'false', 'false');
     request.onreadystatechange = function() {
       if (request.readyState === 4) {
-        if (request.status === 401 || request.status === 405) {
+        if (request.status === 401 || request.status === 405 || request.status === 500) {
           $rootScope.userName = '';
           $rootScope.ticket.principal = '';
           $rootScope.ticket.ticket = '';


Mime
View raw message