zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m...@apache.org
Subject zeppelin git commit: [ZEPPELIN-698] #756 Added new shortcuts but didn't removed old one
Date Fri, 17 Jun 2016 04:41:02 GMT
Repository: zeppelin
Updated Branches:
  refs/heads/branch-0.6 ab712a5f3 -> 68e996789


[ZEPPELIN-698] #756 Added new shortcuts but didn't removed old one

### What is this PR for?

#756 Added new shortcuts but didn't removed old one
https://github.com/apache/zeppelin/pull/756#issuecomment-226423090

### What type of PR is it?
Bug Fix

### Todos
* [x] - Remove old shortcuts

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-698

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <moon@apache.org>

Closes #1029 from Leemoonsoo/ZEPPELIN-698-FOLLOWUP and squashes the following commits:

33f6a46 [Lee moon soo] Remove shortcuts ctrl+alt+1~0-=

(cherry picked from commit f786d1387a7ccae0387e470abb44912d5f322d6b)
Signed-off-by: Lee moon soo <moon@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/68e99678
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/68e99678
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/68e99678

Branch: refs/heads/branch-0.6
Commit: 68e9967895dc40d4af26f4e2759b702550beca00
Parents: ab712a5
Author: Lee moon soo <moon@apache.org>
Authored: Thu Jun 16 07:58:52 2016 -0700
Committer: Lee moon soo <moon@apache.org>
Committed: Thu Jun 16 21:42:47 2016 -0700

----------------------------------------------------------------------
 .../src/app/notebook/paragraph/paragraph.controller.js | 13 -------------
 1 file changed, 13 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/68e99678/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
index 3b4c274..f4afac4 100644
--- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
+++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
@@ -1053,19 +1053,6 @@ angular.module('zeppelinWebApp')
       } else if (keyEvent.ctrlKey && keyEvent.shiftKey && keyCode === 187)
{ // Ctrl + Shift + =
         $scope.paragraph.config.colWidth = Math.min(12, $scope.paragraph.config.colWidth
+ 1);
         $scope.changeColWidth();
-      } else if (keyEvent.ctrlKey && keyEvent.altKey && ((keyCode >= 48
&& keyCode <=57) || keyCode === 189 || keyCode === 187)) { // Ctrl + Alt + [1~9,0,-,=]
-        var colWidth = 12;
-        if (keyCode === 48) {
-          colWidth = 10;
-        } else if (keyCode === 189) {
-          colWidth = 11;
-        } else if (keyCode === 187) {
-          colWidth = 12;
-        } else {
-          colWidth = keyCode - 48;
-        }
-        $scope.paragraph.config.colWidth = colWidth;
-        $scope.changeColWidth();
       } else if (keyEvent.ctrlKey && keyEvent.altKey && keyCode === 84) {
// Ctrl + Alt + t
         if ($scope.paragraph.config.title) {
           $scope.hideTitle();


Mime
View raw message