zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From b..@apache.org
Subject incubator-zeppelin git commit: Hotfix - initial notebook name does not increase.
Date Tue, 31 May 2016 11:28:33 GMT
Repository: incubator-zeppelin
Updated Branches:
  refs/heads/master 734c0ebb9 -> 29723676b


Hotfix - initial notebook name does not increase.

### What is this PR for?
To increase initial notebook name.

### What type of PR is it?
Bug Fix

### How should this be tested?
execute create new note.

### Screenshots (if appropriate)
 - before
![image](https://cloud.githubusercontent.com/assets/3348133/15640275/60d1b67e-2671-11e6-9a46-645f28b1a09a.png)

- after
![image](https://cloud.githubusercontent.com/assets/3348133/15640270/47039e92-2671-11e6-9000-75bfaa5fa21a.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: astroshim <hsshim@nflabs.com>

Closes #929 from astroshim/hotfix/notename and squashes the following commits:

eb0defd [astroshim] list name has changed.


Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/29723676
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/29723676
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/29723676

Branch: refs/heads/master
Commit: 29723676b18170c3c4ecd5ca9c66c74f91163ef9
Parents: 734c0eb
Author: astroshim <hsshim@nflabs.com>
Authored: Mon May 30 14:13:57 2016 +0900
Committer: Alexander Bezzubov <bzz@apache.org>
Committed: Tue May 31 20:28:22 2016 +0900

----------------------------------------------------------------------
 zeppelin-web/src/components/noteName-create/notename.controller.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/29723676/zeppelin-web/src/components/noteName-create/notename.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/components/noteName-create/notename.controller.js b/zeppelin-web/src/components/noteName-create/notename.controller.js
index 5c93053..6965134 100644
--- a/zeppelin-web/src/components/noteName-create/notename.controller.js
+++ b/zeppelin-web/src/components/noteName-create/notename.controller.js
@@ -44,7 +44,7 @@ angular.module('zeppelinWebApp').controller('NotenameCtrl', function($scope,
not
 
   vm.newNoteName = function () {
     var newCount = 1;
-    angular.forEach(vm.notes.list, function (noteName) {
+    angular.forEach(vm.notes.flatList, function (noteName) {
       noteName = noteName.name;
       if (noteName.match(/^Untitled Note [0-9]*$/)) {
         var lastCount = noteName.substr(14) * 1;


Mime
View raw message