zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m...@apache.org
Subject incubator-zeppelin git commit: move noteName method from main to navbar.
Date Tue, 24 May 2016 05:03:36 GMT
Repository: incubator-zeppelin
Updated Branches:
  refs/heads/master 6acd0aee9 -> 89166f0fd


move noteName method from main to navbar.

### What is this PR for?
Notebook list doesn't show when you reload(F5) the zeppelin web page not in home.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-863

### How should this be tested?
Outline the steps to test the PR here.

### Screenshots (if appropriate)
### before
![bug](https://cloud.githubusercontent.com/assets/3348133/15461987/57e6b4fa-20fa-11e6-858f-d354ddbe6c09.gif)

### after
![fix](https://cloud.githubusercontent.com/assets/3348133/15462033/b4246938-20fa-11e6-9a93-4ac0bf5015ba.gif)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: astroshim <hsshim@nflabs.com>

Closes #910 from astroshim/ZEPPELIN-863 and squashes the following commits:

75daf8e [astroshim] move noteName method from main to navbar.


Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/89166f0f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/89166f0f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/89166f0f

Branch: refs/heads/master
Commit: 89166f0fd0e8cc077f574afa36ce3a5b30a7d5e2
Parents: 6acd0ae
Author: astroshim <hsshim@nflabs.com>
Authored: Mon May 23 15:17:21 2016 +0900
Committer: Lee moon soo <moon@apache.org>
Committed: Mon May 23 22:04:35 2016 -0700

----------------------------------------------------------------------
 zeppelin-web/src/app/home/home.controller.js            | 6 ------
 zeppelin-web/src/components/navbar/navbar.controller.js | 6 ++++++
 2 files changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/89166f0f/zeppelin-web/src/app/home/home.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/home/home.controller.js b/zeppelin-web/src/app/home/home.controller.js
index dee1685..589370c 100644
--- a/zeppelin-web/src/app/home/home.controller.js
+++ b/zeppelin-web/src/app/home/home.controller.js
@@ -76,10 +76,4 @@ angular.module('zeppelinWebApp').controller('HomeCtrl', function($scope,
noteboo
     node.hidden = !node.hidden;
   };
 
-  $rootScope.noteName = function(note) {
-    if (!_.isEmpty(note)) {
-      return arrayOrderingSrv.getNoteName(note);
-    }
-  };
-
 });

http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/89166f0f/zeppelin-web/src/components/navbar/navbar.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/components/navbar/navbar.controller.js b/zeppelin-web/src/components/navbar/navbar.controller.js
index b56ee68..0e1d150 100644
--- a/zeppelin-web/src/components/navbar/navbar.controller.js
+++ b/zeppelin-web/src/components/navbar/navbar.controller.js
@@ -103,6 +103,12 @@ angular.module('zeppelinWebApp').controller('NavCtrl', function($scope,
$rootSco
     return ($routeParams.noteId === noteId);
   }
 
+  $rootScope.noteName = function(note) {
+    if (!_.isEmpty(note)) {
+      return arrayOrderingSrv.getNoteName(note);
+    }
+  };
+
   vm.loadNotes = loadNotes;
   vm.isActive = isActive;
 


Mime
View raw message