zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixche...@apache.org
Subject incubator-zeppelin git commit: Add some information about how we can review and test PR quickly
Date Thu, 21 Jan 2016 01:23:23 GMT
Repository: incubator-zeppelin
Updated Branches:
  refs/heads/master 1d86d9b27 -> dcda63eb2

Add some information about how we can review and test PR quickly

### What is this PR for?
Zeppelin has already provided a useful utility for reviewing PR ( #513 ). So I added a **Testing
a Pull Request** section to `CONTRIBUTING.md` for whom to review and test PR quickly.

### What type of PR is it?

### Todos
* [x] - Add a **Testing a Pull Request** section to CONTRIBUTING.md

### Is there a relevant Jira issue?
[ZEPPELIN-484](https://issues.apache.org/jira/browse/ZEPPELIN-484) and PR #513

### How should this be tested?

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Ryu Ah young <fbdkdud93@hanmail.net>

Closes #656 from AhyoungRyu/add_pr_review_information and squashes the following commits:

5f370d5 [Ryu Ah young] Fix some grammar errors
3781550 [Ryu Ah young] Delete 'like'
9ced186 [Ryu Ah young] Add some information about how we can review and test PR

Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/dcda63eb
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/dcda63eb
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/dcda63eb

Branch: refs/heads/master
Commit: dcda63eb242d81a0b46644d8f20beae18ccd7b29
Parents: 1d86d9b
Author: Ryu Ah young <fbdkdud93@hanmail.net>
Authored: Wed Jan 20 15:38:31 2016 +0900
Committer: Felix Cheung <felixcheung@apache.org>
Committed: Wed Jan 20 17:23:18 2016 -0800

 CONTRIBUTING.md | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

index e18ea1b..f40e808 100644
@@ -39,6 +39,29 @@ You can also use this small bookmarklet tool to fill your Pull Request
fields au
 javascript:(function() {var e = document.getElementById('pull_request_body');if (e) {e.value
+= '### What is this PR for?\nA few sentences describing the overall goals of the pull request\'s
commits.\n\n### What type of PR is it?\n[Bug Fix | Improvement | Feature | Documentation |
Hot Fix | Refactoring]\n\n### Todos\n* [ ] - Task\n\n### Is there a relevant Jira issue?\n\n###
How should this be tested?\nOutline the steps to test the PR here.\n\n### Screenshots (if
appropriate)\n\n### Questions:\n* Does the licenses files need update?\n* Is there breaking
changes for older versions?\n* Does this needs documentation?';}})();
+## Testing a Pull Request
+You can also test and review a particular Pull Request. Here are two useful ways.
+* Using a utility provided from Zeppelin. 
+    ```
+    dev/test_zeppelin_pr.py [# of PR]
+    ```
+    For example, if you want to test `#513`, then the command will be:
+    ```
+    dev/test_zeppelin_pr.py 513
+    ```
+* Another way is using [github/hub](https://github.com/github/hub). 
+    ```
+    hub checkout https://github.com/apache/incubator-zeppelin/pull/[# of PR]
+    ```
+The above two methods will help you test and review Pull Requests.
 ## Source Control Workflow
 Zeppelin follows [Fork & Pull] (https://github.com/sevntu-checkstyle/sevntu.checkstyle/wiki/Development-workflow-with-Git:-Fork,-Branching,-Commits,-and-Pull-Request)
@@ -53,7 +76,6 @@ When a Pull Request is submitted, it is being merged or rejected by following
 * Committer can initiate lazy consensus ("Merge if there is no more discussion") and the
code can be merged after certain time (normally 24 hours) when there is no review exists.
 * Contributor can ping reviewers (including committer) by commenting 'Ready to review' or
suitable indication.
 ## Becoming a Committer
 The PPMC adds new committers from the active contributors, based on their contribution to
Zeppelin. The qualifications for new committers include:

View raw message