zeppelin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cornead...@apache.org
Subject incubator-zeppelin git commit: [ZEPPELIN-328] Interpreter page should clarify the % magic syntax for interpreter group.name
Date Thu, 15 Oct 2015 05:04:51 GMT
Repository: incubator-zeppelin
Updated Branches:
  refs/heads/master 47df1cd1d -> 77f7faec2

[ZEPPELIN-328] Interpreter page should clarify the % magic syntax for interpreter group.name

Currently the Interpreter page like the interpreters as
hive %hql
However, this does not work unless hive is the default group - otherwise one would require
the full %group.name.
It seems it would be better to list interpreter as %group.name on the page.

Author: Felix Cheung <felixcheung_m@hotmail.com>

Closes #328 from felixcheung/interpretername and squashes the following commits:

656f97c [Felix Cheung] Merge commit '81e823eb141cb0766c604f18c3bbfdb0bb8746d3' into interpretername
c3c8132 [Felix Cheung] show default group explicitly and without optional group prefix
ff4d843 [Felix Cheung] update to not show the interpreter.name for the first one in the group
c6ac23a [Felix Cheung] Update interpreter page to list full %group.name

Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/77f7faec
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/77f7faec
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/77f7faec

Branch: refs/heads/master
Commit: 77f7faec2a88d627e33ee7810c607123a717d145
Parents: 47df1cd
Author: Felix Cheung <felixcheung_m@hotmail.com>
Authored: Thu Oct 8 17:17:51 2015 -0700
Committer: Damien CORNEAU <dcorneau@Casimir.local>
Committed: Thu Oct 15 14:04:37 2015 +0900

 zeppelin-web/src/app/interpreter/interpreter.html | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/zeppelin-web/src/app/interpreter/interpreter.html b/zeppelin-web/src/app/interpreter/interpreter.html
index 69b4766..3d6cbc9 100644
--- a/zeppelin-web/src/app/interpreter/interpreter.html
+++ b/zeppelin-web/src/app/interpreter/interpreter.html
@@ -39,12 +39,14 @@ limitations under the License.
     <div class="row interpreter">
       <div class="col-md-12">
-        <h3 class="interpreter-title">{{setting.name}} 
+        <h3 class="interpreter-title">{{setting.name}}
             <span ng-repeat="interpreter in setting.interpreterGroup"
-              <span ng-show="!$first">, </span>
-              %{{interpreter.name}}
+              <span ng-show="$parent.$first && $first">%{{setting.name}} (default)</span>
+              <span ng-show="$parent.$first && !$first">, %{{interpreter.name}}</span>
+              <span ng-show="!$parent.$first && $first">%{{setting.name}}</span>
+              <span ng-show="!$parent.$first && !$first">, %{{setting.name}}.{{interpreter.name}}</span>

View raw message